nada/fix: handle tab switching when changing language #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nada-deriv
requested review from
ali-hosseini-deriv,
yashim-deriv,
azmib-developer and
farrah-deriv
as code owners
nada-deriv
changed the title
|
Preview Link: https://nada-tab-switch-issu.deriv-p2p-app.pages.dev
|
Pull Request Test Coverage Report for Build 9414017046Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9414015516Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9414051224Details
💛 - Coveralls |
shayan-deriv
approved these changes
Jun 7, 2024
niloofar-deriv
approved these changes
Jun 7, 2024
farrah-deriv
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2024-06-07.at.12.19.50.PM.mov
Since the tab title is localized, and the tab components takes the tab title as the active tab, when switching the language, the tab doesn't work properly. hence need to pass the localized active tab to the tab component instead of the direct tab string.
this is a temporary fix, since changing the tab component to accept the index might affect the other apps.