Nada/feat: implementation of copy ads #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nada-deriv
changed the title
Pull Request Test Coverage Report for Build 9401031472Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9403484156Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9406568005Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9406999844Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9407262061Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9407266613Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9407297662Details
💛 - Coveralls |
nada-deriv
requested review from
ali-hosseini-deriv,
yashim-deriv,
azmib-developer and
farrah-deriv
as code owners
farrah-deriv
reviewed
Jun 7, 2024
Comment on lines
+93
to
+94
| const labelSize = isMobile ? 'sm' : 'xs'; | ||
| const valueSize = isMobile ? 'md' : 'sm'; |
There was a problem hiding this comment.
We need to start to consider the tablet view.
Suggested change
| const labelSize = isMobile ? 'sm' : 'xs'; | |
| const valueSize = isMobile ? 'md' : 'sm'; | |
| const labelSize = isDesktop ? 'xs' : 'sm'; | |
| const valueSize = isDesktop ? 'sm' : 'md'; |
There was a problem hiding this comment.
since this uses the same components as the ones in create/edit ad it might break the existing ones.
There was a problem hiding this comment.
probs we need to create another card to check the responsive sizings for the whole of v2
There was a problem hiding this comment.
yeah.. also we might need design.. because for the copy ads i tried the mobile design for tablet and it looks really bad..
Pull Request Test Coverage Report for Build 9412383731Details
💛 - Coveralls |
| const CopyAdForm = ({ | ||
| formValues, | ||
| isModalOpen, | ||
| onClickCancel, |
There was a problem hiding this comment.
can't we use the onRequestClose for this? 🤔
There was a problem hiding this comment.
i have removed the prop. its not needed.
Pull Request Test Coverage Report for Build 9444143006Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
shayan-deriv
approved these changes
Jun 10, 2024
ameerul-deriv
approved these changes
Jun 10, 2024
|
Preview Link: https://nada-FEQ-2197-copy-a.deriv-p2p-app.pages.dev
|
Pull Request Test Coverage Report for Build 9445264013Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
farrah-deriv
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2024-06-06.at.3.51.43.PM.mov
Screen.Recording.2024-06-06.at.11.13.49.PM.mov
Copy advert feature
Fix issue with validation in create/edit ad
Fix order completion time not passed in create/edit ad