Merge pull request #120 from farrah-deriv/P2PS-2883/disable-ad-menu

farrah/P2PS-2883/fix: disable advert menu
deriv-com · Jun 14, 2024 · 7837d5f · 7837d5f
2 parents ed8e8df + 0e23d4c
commit 7837d5f
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 10 deletions.
diff --git a/src/components/PopoverDropdown/PopoverDropdown.tsx b/src/components/PopoverDropdown/PopoverDropdown.tsx
@@ -25,13 +25,17 @@ const PopoverDropdown = ({ dropdownList, onClick, tooltipMessage }: TPopoverDrop
 
     return (
         <div className='popover-dropdown' ref={ref}>
-            <TooltipMenuIcon
-                as='button'
-                onClick={() => setVisible(prevState => !prevState)}
-                tooltipContent={tooltipMessage}
-            >
-                <LabelPairedEllipsisVerticalLgBoldIcon data-testid='dt_popover_dropdown_icon' />
-            </TooltipMenuIcon>
+            {isAdvertiserBarred ? (
+                <LabelPairedEllipsisVerticalLgBoldIcon data-testid='dt_popover_dropdown_icon' fill='#999999' />
+            ) : (
+                <TooltipMenuIcon
+                    as='button'
+                    onClick={() => setVisible(prevState => !prevState)}
+                    tooltipContent={tooltipMessage}
+                >
+                    <LabelPairedEllipsisVerticalLgBoldIcon data-testid='dt_popover_dropdown_icon' />
+                </TooltipMenuIcon>
+            )}
             {visible && (
                 <div className='popover-dropdown__list'>
                     {dropdownList.map(item => (

diff --git a/src/components/PopoverDropdown/__tests__/PopoverDropdown.spec.tsx b/src/components/PopoverDropdown/__tests__/PopoverDropdown.spec.tsx
@@ -48,10 +48,9 @@ describe('PopoverDropdown', () => {
         expect(mockProps.onClick).toHaveBeenCalledWith('value 1');
     });
 
-    it('should disable the button if advertiser is barred', async () => {
+    it('should disable the icon if advertiser is barred', async () => {
         mockUseIsAdvertiserBarred.mockReturnValue(true);
         render(<PopoverDropdown {...mockProps} />);
-        await userEvent.click(screen.getByTestId('dt_popover_dropdown_icon'));
-        expect(screen.getByRole('button', { name: 'label 1' })).toBeDisabled();
+        expect(screen.getByTestId('dt_popover_dropdown_icon')).not.toHaveProperty('onClick');
     });
 });