Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(analytics): implement Equatable to UserInfo model for unit test purpose #904

Open
wants to merge 669 commits into
base: dev
Choose a base branch
from

Conversation

anas-deriv
Copy link
Contributor

Clickup link:
Fixes issue: #

This PR contains the following changes:

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Developers Note (Optional)

Pre-launch Checklist (For PR creator)

As a creator of this PR:

  • ✍️ I have included clickup id and package/app_name in the PR title.
  • 👁️ I have gone through the code and removed any temporary changes (commented lines, prints, debug statements etc.).
  • ⚒️ I have fixed any errors/warnings shown by the analyzer/linter.
  • 📝 I have added documentation, comments and logging wherever required.
  • 🧪 I have added necessary tests for these changes.
  • 🔎 I have ensured all existing tests are passing.

Reviewers

Pre-launch Checklist (For Reviewers)

As a reviewer I ensure that:

  • ✴️ This PR follows the standard PR template.
  • 🪩 The information in this PR properly reflects the code changes.
  • 🧪 All the necessary tests for this PR's are passing.

Pre-launch Checklist (For QA)

  • 👌 It passes the acceptance criteria.

Pre-launch Checklist (For Maintainer)

  • [MAINTAINER_NAME] I make sure this PR fulfills its purpose.

ilya-deriv and others added 30 commits June 27, 2024 15:53
Co-authored-by: GitHub Actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: emad-deriv <[email protected]>
…on_Deriv_Go (#603)

Co-authored-by: Illya Tsai <[email protected]>
Co-authored-by: Illya Tsai <[email protected]>
Co-authored-by: Osama Ghazal <[email protected]>
Co-authored-by: GitHub Actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: osama-deriv <[email protected]>
Co-authored-by: GitHub Actions <41898282+github-actions[bot]@users.noreply.github.com>
fix(deriv_auth): fix login provider being null
Co-authored-by: GitHub Actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: ahrar-deriv <[email protected]>
Co-authored-by: GitHub Actions <41898282+github-actions[bot]@users.noreply.github.com>
…ate_token_assigned

chore(deriv_auth): fix_forced_logout_if_no_token_found_for_a_loginId
Co-authored-by: GitHub Actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: sahani-deriv <[email protected]>
mobile-apps-deriv and others added 23 commits October 22, 2024 14:02
Co-authored-by: GitHub Actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: aliakbar-deriv <[email protected]>
Co-authored-by: GitHub Actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: aliakbar-deriv <[email protected]>
Co-authored-by: GitHub Actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: aliakbar-deriv <[email protected]>
Co-authored-by: GitHub Actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: aliakbar-deriv <[email protected]>
Co-authored-by: GitHub Actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: aliakbar-deriv <[email protected]>
Co-authored-by: GitHub Actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: sahani-deriv <[email protected]>
Co-authored-by: GitHub Actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: zohreh-deriv <[email protected]>
… remote config" error (#871)

Co-authored-by: ramin-deriv <[email protected]>
Co-authored-by: GitHub Actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: ramin-deriv <[email protected]>
…nch app, ios support, isAppInstalled function) to deriv_store_launcher. (#875)
Co-authored-by: GitHub Actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: aliakbar-deriv <[email protected]>
Co-authored-by: GitHub Actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: aliakbar-deriv <[email protected]>
@anas-deriv anas-deriv self-assigned this Nov 15, 2024
Reza-deriv
Reza-deriv previously approved these changes Nov 15, 2024
@aliakbar-deriv aliakbar-deriv changed the title fix: implement Equatable to UserInfo model for unit test purpose fix(analytics): implement Equatable to UserInfo model for unit test purpose Nov 18, 2024
@anas-deriv anas-deriv changed the base branch from master to dev December 23, 2024 05:54
@anas-deriv anas-deriv dismissed Reza-deriv’s stale review December 23, 2024 05:54

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.