-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(deriv_logger): [DERG-2590] Add ability to inspect incoming and outgoing network payloads in UI #685
Merged
sahani-deriv
merged 23 commits into
deriv-com:master
from
sagar-deriv:deriv_logger/add_network_logs
Jul 19, 2024
Merged
feat(deriv_logger): [DERG-2590] Add ability to inspect incoming and outgoing network payloads in UI #685
sahani-deriv
merged 23 commits into
deriv-com:master
from
sagar-deriv:deriv_logger/add_network_logs
Jul 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagar-deriv
changed the title
feat: [DERG-2590] Add ability to inspect incoming and outgoing network payloads in UI
feat(deriv_logger): [DERG-2590] Add ability to inspect incoming and outgoing network payloads in UI
Jul 11, 2024
sagar-deriv
force-pushed
the
deriv_logger/add_network_logs
branch
from
July 11, 2024 12:33
c2e2bdf
to
6e7d274
Compare
ayaan-deriv
reviewed
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like some missing documentations. @sagar-deriv can you take a look at this file and add documentation wherever required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. I will do that.
sagar-deriv
force-pushed
the
deriv_logger/add_network_logs
branch
from
July 12, 2024 07:39
6e7d274
to
7089a1d
Compare
ayaan-deriv
approved these changes
Jul 16, 2024
sagar-deriv
force-pushed
the
deriv_logger/add_network_logs
branch
from
July 18, 2024 07:58
7089a1d
to
8b9a3f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clickup link: https://app.clickup.com/t/20696747/DERG-2590
This PR contains the following changes:
Pre-launch Checklist (For PR creator)
As a creator of this PR:
Reviewers
@ayaan-deriv