Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deriv_logger): [DERG-2590] Add ability to inspect incoming and outgoing network payloads in UI #685

Merged

Conversation

sagar-deriv
Copy link
Contributor

@sagar-deriv sagar-deriv commented Jul 11, 2024

Clickup link: https://app.clickup.com/t/20696747/DERG-2590

This PR contains the following changes:

  • Add UI for subscription and Network calls
  • Add controllers for handling logs in UI
  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Pre-launch Checklist (For PR creator)

As a creator of this PR:

  • ✍️ I have included clickup id and package/app_name in the PR title.
  • 👁️ I have gone through the code and removed any temporary changes (commented lines, prints, debug statements etc.).
  • ⚒️ I have fixed any errors/warnings shown by the analyzer/linter.
  • 📝 I have added documentation, comments and logging wherever required.
  • 🧪 I have added necessary tests for these changes.
  • 🔎 I have ensured all existing tests are passing.

Reviewers

@ayaan-deriv

@sagar-deriv sagar-deriv changed the title feat: [DERG-2590] Add ability to inspect incoming and outgoing network payloads in UI feat(deriv_logger): [DERG-2590] Add ability to inspect incoming and outgoing network payloads in UI Jul 11, 2024
@sagar-deriv sagar-deriv force-pushed the deriv_logger/add_network_logs branch from c2e2bdf to 6e7d274 Compare July 11, 2024 12:33
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like some missing documentations. @sagar-deriv can you take a look at this file and add documentation wherever required.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I will do that.

@sagar-deriv sagar-deriv force-pushed the deriv_logger/add_network_logs branch from 6e7d274 to 7089a1d Compare July 12, 2024 07:39
@sagar-deriv sagar-deriv requested a review from ramin-deriv July 17, 2024 07:52
@sagar-deriv sagar-deriv force-pushed the deriv_logger/add_network_logs branch from 7089a1d to 8b9a3f6 Compare July 18, 2024 07:58
@sahani-deriv sahani-deriv merged commit 4cd38b2 into deriv-com:master Jul 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants