Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deriv_mobile_chart_wrapper): Add Indicator bottom sheet and categories_ #683

Merged
merged 14 commits into from
Jul 18, 2024

Conversation

behnam-deriv
Copy link
Contributor

Clickup link: https://app.clickup.com/t/20696747/DERG-2560

This PR contains the following changes:

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Developers Note (Optional)

Pre-launch Checklist (For PR creator)

As a creator of this PR:

  • ✍️ I have included clickup id and package/app_name in the PR title.
  • 👁️ I have gone through the code and removed any temporary changes (commented lines, prints, debug statements etc.).
  • ⚒️ I have fixed any errors/warnings shown by the analyzer/linter.
  • 📝 I have added documentation, comments and logging wherever required.
  • 🧪 I have added necessary tests for these changes.
  • 🔎 I have ensured all existing tests are passing.

Reviewers

Pre-launch Checklist (For Reviewers)

As a reviewer I ensure that:

  • ✴️ This PR follows the standard PR template.
  • 🪩 The information in this PR properly reflects the code changes.
  • 🧪 All the necessary tests for this PR's are passing.

Pre-launch Checklist (For QA)

  • 👌 It passes the acceptance criteria.

Pre-launch Checklist (For Maintainer)

  • [MAINTAINER_NAME] I make sure this PR fulfills its purpose.

@behnam-deriv behnam-deriv force-pushed the indicator-category-chips branch from ed3fde6 to 5c6bafb Compare July 12, 2024 11:26
@behnam-deriv behnam-deriv marked this pull request as ready for review July 12, 2024 11:31
@ramin-deriv ramin-deriv changed the title feat(deriv_mobile_chart_wrapper): Add Indicator bottom sheet and categories feat(deriv_mobile_chart_wrapper): Add Indicator bottom sheet and categories_ Jul 18, 2024
@ramin-deriv ramin-deriv merged commit a32c7ed into deriv-com:master Jul 18, 2024
3 checks passed
@ramin-deriv ramin-deriv deleted the indicator-category-chips branch July 18, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants