Naif/add-default-token-login-tracking. #671
Conversation
naif-deriv
changed the title
| 'event': 'login_flow_error', | ||
| 'properties': <String, dynamic>{ | ||
| 'app_id': appId, | ||
| 'login_provider': 'deafult_token', |
There was a problem hiding this comment.
what does this mean ? and it has a typo. default not deafult
There was a problem hiding this comment.
This will be used when the user is automatically logged in using the saved token.
There was a problem hiding this comment.
Oh I see, what it is considered as error ? login_flow_error
There was a problem hiding this comment.
-
The thing is, I faced this issue when the default token belonged to an account to qa10 before it was rebuilt, after rebuilding, the app would automatically log in using the token of a
non-existentaccount, and it would throw an error. -
When RudderStack tries to handle this error, it refuses to do so because of missing params,
login_providerwhich is what type of log in was initiated, and thatdefault tokentype was not being handled. -
Theoretically, this never happens on production, but still, developers will face it at least once every qa rebuild, and it makes sense to handle it.
There was a problem hiding this comment.
thank you for the explanation. Understood. Looks good to me. Just ensure this is clear to Reeja and the people who would be analysing the data.
|
please fix the title and update the PR. We should be able to marge aftewards. |
Clickup link:
Fixes issue: #
This PR contains the following changes:
Developers Note (Optional)
Pre-launch Checklist (For PR creator)
As a creator of this PR:
Reviewers
Pre-launch Checklist (For Reviewers)
As a reviewer I ensure that:
Pre-launch Checklist (For QA)
Pre-launch Checklist (For Maintainer)