Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add workflow to check if versioning pr exists #645

Merged
merged 13 commits into from
Jun 28, 2024

Conversation

sahani-deriv
Copy link
Contributor

@sahani-deriv sahani-deriv commented Jun 26, 2024

Clickup link: https://app.clickup.com/t/20696747/DERG-2546
Fixes issue: #

This PR contains the following changes:

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Developers Note (Optional)

Pre-launch Checklist (For PR creator)

As a creator of this PR:

  • ✍️ I have included clickup id and package/app_name in the PR title.
  • 👁️ I have gone through the code and removed any temporary changes (commented lines, prints, debug statements etc.).
  • ⚒️ I have fixed any errors/warnings shown by the analyzer/linter.
  • 📝 I have added documentation, comments and logging wherever required.
  • 🧪 I have added necessary tests for these changes.
  • 🔎 I have ensured all existing tests are passing.

Reviewers

Pre-launch Checklist (For Reviewers)

As a reviewer I ensure that:

  • ✴️ This PR follows the standard PR template.
  • 🪩 The information in this PR properly reflects the code changes.
  • 🧪 All the necessary tests for this PR's are passing.

Pre-launch Checklist (For QA)

  • 👌 It passes the acceptance criteria.

Pre-launch Checklist (For Maintainer)

  • [MAINTAINER_NAME] I make sure this PR fulfills its purpose.

@ahrar-deriv
Copy link
Contributor

ahrar-deriv commented Jun 26, 2024

for better clarity, i think we can also comment why the pr is blocked

uses: marocchino/sticky-pull-request-comment@4b7290acd5c5b99ef9995db30e52150e705d2475
        with:
          GITHUB_TOKEN: ${{ THE TOKEN }}
          message: |
            **Merge Is BLOCKED : we still have a chore(version) pr open, please merge that pr first ** 

@sahani-deriv sahani-deriv force-pushed the check-versioning-pr branch from 6d832b7 to e32101c Compare June 26, 2024 10:38
@sahani-deriv sahani-deriv force-pushed the check-versioning-pr branch from 848dc0e to f625a80 Compare June 28, 2024 02:19
@deriv-com deriv-com deleted a comment from mobile-apps-deriv Jun 28, 2024
@deriv-com deriv-com deleted a comment from mobile-apps-deriv Jun 28, 2024
@deriv-com deriv-com deleted a comment from mobile-apps-deriv Jun 28, 2024
} else {
console.log("No version bump pull request found.");
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is passing even if we have chore available. this is just printing to console log

uses: marocchino/sticky-pull-request-comment@4b7290acd5c5b99ef9995db30e52150e705d2475
with:
GITHUB_TOKEN: ${{ secrets.PAT }}
message: |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exit 1 is needed if this is true. and please double check if secrets.PAT has comment access I don't see any comment message on the pr

@ahrar-deriv ahrar-deriv merged commit 7707c88 into deriv-com:master Jun 28, 2024
3 checks passed
@ahrar-deriv ahrar-deriv deleted the check-versioning-pr branch June 28, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants