Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deriv_ui): [DERG 2450] Added Timeline Widget to Deriv UI #631

Conversation

akhil-deriv
Copy link
Contributor

@akhil-deriv akhil-deriv commented Jun 24, 2024

Clickup link: https://app.clickup.com/t/20696747/DERG-2450
Fixes issue: added the Timeline widget to Deriv UI package

This PR contains the following changes:

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Developers Note (Optional)

Pre-launch Checklist (For PR creator)

As a creator of this PR:

  • ✍️ I have included clickup id and package/app_name in the PR title.
  • 👁️ I have gone through the code and removed any temporary changes (commented lines, prints, debug statements etc.).
  • ⚒️ I have fixed any errors/warnings shown by the analyzer/linter.
  • 📝 I have added documentation, comments and logging wherever required.
  • 🧪 I have added necessary tests for these changes.
  • 🔎 I have ensured all existing tests are passing.

Reviewers

Pre-launch Checklist (For Reviewers)

As a reviewer I ensure that:

  • ✴️ This PR follows the standard PR template.
  • 🪩 The information in this PR properly reflects the code changes.
  • 🧪 All the necessary tests for this PR's are passing.

Pre-launch Checklist (For QA)

  • 👌 It passes the acceptance criteria.

Pre-launch Checklist (For Maintainer)

  • [MAINTAINER_NAME] I make sure this PR fulfills its purpose.

Copy link
Contributor

@ahrar-deriv ahrar-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update your title to include the feat(deriv_ui)

@akhil-deriv akhil-deriv changed the title feat: [DERG 2450] akhil/2450/crypto_transaction_details_page feat(deriv_ui): [DERG 2450] akhil/2450/crypto_transaction_details_page Jul 3, 2024
@akhil-deriv akhil-deriv changed the title feat(deriv_ui): [DERG 2450] akhil/2450/crypto_transaction_details_page feat(deriv_ui): [DERG 2450] Added Timeline Widget to Deriv UI Jul 15, 2024
@sagar-deriv sagar-deriv merged commit e34d78b into deriv-com:master Jul 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants