feat(deriv_auth): add log in user tracking events. #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abedelaziz-deriv
suggested changes
Jun 19, 2024
| import 'package:deriv_auth/deriv_auth.dart'; | ||
| import 'package:deriv_auth/core/analytics/data/auth_tracking_repository.dart'; | ||
|
|
||
| /// |
Comment on lines
+136
to
+137
| default: | ||
| break; |
| switch (socialAuthProvider) { | ||
| case SocialAuthProvider.google: | ||
| trackLoginWithGoogle(); | ||
| break; |
There was a problem hiding this comment.
breaks can be removed
Comment on lines
13
to
17
| BaseAuthService({ | ||
| required this.authRepository, | ||
| required this.jwtService, | ||
| required this.connectionInfo, | ||
| required this.tokenService, |
There was a problem hiding this comment.
i believe this change would break the example app in this package
| @@ -1,4 +1,7 @@ | |||
| import 'package:analytics/sdk/rudderstack/sdk/deriv_rudderstack_sdk.dart'; | |||
There was a problem hiding this comment.
I don't see analytics package added to pubspec.yaml
|
|
||
| /// | ||
| mixin AuthTrackingMixin { | ||
| final AuthTrackingRepository _repository = AuthTrackingRepository.instance; |
There was a problem hiding this comment.
please make this late. Otherwise it will be executed always before the repository's init function.
| @@ -136,6 +151,8 @@ class DerivAuthCubit extends Cubit<DerivAuthState> implements DerivAuthIO { | |||
| await authService.getLandingCompany(authorizeEntity.country); | |||
| _isUserMigrated = _checkUserMigrated(authorizeEntity); | |||
|
|
|||
| trackLoginFinished(); | |||
There was a problem hiding this comment.
can we add this to _loginRequest() as well?
abedelaziz-deriv
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clickup link:
Fixes issue: #
This PR contains the following changes:
Developers Note (Optional)
Pre-launch Checklist (For PR creator)
As a creator of this PR:
Reviewers
Pre-launch Checklist (For Reviewers)
As a reviewer I ensure that:
Pre-launch Checklist (For QA)
Pre-launch Checklist (For Maintainer)