Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(analytics): ilya/DERG-2409/Add_tracking_to_real_account_sign_up_on_Deriv_Go #603

Conversation

ilya-deriv
Copy link
Contributor

@ilya-deriv ilya-deriv commented Jun 6, 2024

https://app.clickup.com/t/20696747/DERG-2409

This PR contains the following changes:

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Developers Note (Optional)

Pre-launch Checklist (For PR creator)

As a creator of this PR:

  • ✍️ I have included clickup id and package/app_name in the PR title.
  • 👁️ I have gone through the code and removed any temporary changes (commented lines, prints, debug statements etc.).
  • ⚒️ I have fixed any errors/warnings shown by the analyzer/linter.
  • 📝 I have added documentation, comments and logging wherever required.
  • 🧪 I have added necessary tests for these changes.
  • 🔎 I have ensured all existing tests are passing.

Reviewers

Pre-launch Checklist (For Reviewers)

As a reviewer I ensure that:

  • ✴️ This PR follows the standard PR template.
  • 🪩 The information in this PR properly reflects the code changes.
  • 🧪 All the necessary tests for this PR's are passing.

Pre-launch Checklist (For QA)

  • 👌 It passes the acceptance criteria.

Pre-launch Checklist (For Maintainer)

  • [MAINTAINER_NAME] I make sure this PR fulfills its purpose.

@ilya-deriv ilya-deriv changed the title ilya/2409/Add_tracking_to_real_account_sign_up_on_Deriv_Go feat: ilya/2409/Add_tracking_to_real_account_sign_up_on_Deriv_Go Jun 6, 2024
@ilya-deriv ilya-deriv changed the title feat: ilya/2409/Add_tracking_to_real_account_sign_up_on_Deriv_Go feat(analytics): ilya/DERG-2409/Add_tracking_to_real_account_sign_up_on_Deriv_Go Jun 6, 2024
'action': 'step_passed',
'step_codename': stepCodename,
'step_num': stepNum,
'user_choise': userChoice,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'user_choise': userChoice,
'user_choice': userChoice,

Comment on lines 199 to 216
/// Tracks when the user presses the next button
/// and the step is successfully passed.
void logStepPassedRealSignUp(
[String? stepNum,
String? stepCodename,
List<Map<String, dynamic>>? userChoice]) {
DerivRudderstack().track(
eventName: 'ce_real_account_signup_form',
properties: RudderProperty.fromMap(<String, dynamic>{
'action': 'step_passed',
'step_codename': stepCodename,
'step_num': stepNum,
'user_choise': userChoice,
'form_source': 'mobile_derivgo',
'form_name': 'real_signup_derivgo'
}),
);
}
Copy link
Contributor

@horam-deriv horam-deriv Jun 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// Tracks when the user presses the next button
/// and the step is successfully passed.
void logStepPassedRealSignUp(
[String? stepNum,
String? stepCodename,
List<Map<String, dynamic>>? userChoice]) {
DerivRudderstack().track(
eventName: 'ce_real_account_signup_form',
properties: RudderProperty.fromMap(<String, dynamic>{
'action': 'step_passed',
'step_codename': stepCodename,
'step_num': stepNum,
'user_choise': userChoice,
'form_source': 'mobile_derivgo',
'form_name': 'real_signup_derivgo'
}),
);
}
/// Tracks when the user presses the next button
/// and the step is successfully passed.
void logStepPassedRealSignUp(
[String? stepNum,
String? stepCodename,
Map<String, dynamic>? userChoice]) {
DerivRudderstack().track(
eventName: 'ce_real_account_signup_form',
properties: RudderProperty.fromMap(<String, dynamic>{
'action': 'step_passed',
'step_codename': stepCodename,
'step_num': stepNum,
'user_choice': userChoice,
'form_source': 'mobile_derivgo',
'form_name': 'real_signup_derivgo'
}),
);
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilya-deriv I am not sure if we need to pass a list of a map as userChoice 🤔

@ilya-deriv ilya-deriv force-pushed the Add_tracking_to_real_account_sign_up_on_Deriv_Go branch from a6f1167 to 2edf83f Compare June 18, 2024 14:08
@ilya-deriv ilya-deriv force-pushed the Add_tracking_to_real_account_sign_up_on_Deriv_Go branch from 66f0035 to 32b933b Compare June 20, 2024 09:20
@osama-deriv osama-deriv changed the base branch from master to dev June 26, 2024 09:10
@osama-deriv osama-deriv changed the base branch from dev to master June 26, 2024 09:10
@osama-deriv osama-deriv merged commit 9ada725 into deriv-com:master Jun 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants