fix(auth_single_entry): Update settings page navigation in auth flow with callback #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eriv/flutter-deriv-packages into Ernest/settings_page_navigation
packages/deriv_auth/lib/features/single_entry/core/models/setting_page_model.dart
Outdated
Show resolved
Hide resolved
| @@ -7,6 +9,7 @@ class SettingPageModel { | |||
| required this.endpoint, | |||
| required this.saveValues, | |||
| required this.updateFlavorConfigs, | |||
| required this.settingsPageNavigation, | |||
There was a problem hiding this comment.
can you make it nullable? If null use the package setting page.
There was a problem hiding this comment.
@sahani-deriv I have made it nullable. Thanks
sahani-deriv
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
**Clickup link:**https://app.clickup.com/t/20696747/DERG-2134
This PR contains the following changes:
Developers Note (Optional)
Updating the settings page navigation is a way that the client applications can provide the settings page navigation as a callback. The Deriv Go application setting page is very specific to the application and this approach is preferred at the moment.
Pre-launch Checklist (For PR creator)
As a creator of this PR:
Reviewers
Pre-launch Checklist (For Reviewers)
As a reviewer I ensure that:
Pre-launch Checklist (For QA)
Pre-launch Checklist (For Maintainer)