Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(analytics): [DERG-1502 ]Account sign up #546

Merged
merged 10 commits into from
May 7, 2024

Conversation

ilya-deriv
Copy link
Contributor

@ilya-deriv ilya-deriv commented Mar 28, 2024

https://app.clickup.com/t/20696747/DERG-1502

This PR contains the following changes:

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Developers Note (Optional)

Pre-launch Checklist (For PR creator)

As a creator of this PR:

  • ✍️ I have included clickup id and package/app_name in the PR title.
  • 👁️ I have gone through the code and removed any temporary changes (commented lines, prints, debug statements etc.).
  • ⚒️ I have fixed any errors/warnings shown by the analyzer/linter.
  • 📝 I have added documentation, comments and logging wherever required.
  • 🧪 I have added necessary tests for these changes.
  • 🔎 I have ensured all existing tests are passing.

Reviewers

@zohreh-deriv

Pre-launch Checklist (For Reviewers)

As a reviewer I ensure that:

  • ✴️ This PR follows the standard PR template.
  • 🪩 The information in this PR properly reflects the code changes.
  • 🧪 All the necessary tests for this PR's are passing.

Pre-launch Checklist (For QA)

  • 👌 It passes the acceptance criteria.

Pre-launch Checklist (For Maintainer)

  • [MAINTAINER_NAME] I make sure this PR fulfills its purpose.

@ilya-deriv ilya-deriv changed the title ilya/1502/Account_sign_up fix(deriv_rudderstack): [DERG-1502 ]Account sign up Mar 28, 2024
'form_name': 'virtual_signup_derivgo'
});
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rudderanalytics.track("ce_virtual_signup_form", { action: "signup_flow_error", signup_provider: "facebook", error_message: "Some error description", form_source: "mobile_derivgo", form_name: "virtual_signup_derivgo" })

Is missed. Is there any specific reason?

@ilya-deriv ilya-deriv force-pushed the Account_sign_up branch 7 times, most recently from c61da25 to 353316c Compare May 7, 2024 07:00
@ilya-deriv ilya-deriv requested a review from aliakbar-deriv May 7, 2024 10:37
@aliakbar-deriv aliakbar-deriv merged commit bbb270f into deriv-com:master May 7, 2024
2 checks passed
@aliakbar-deriv aliakbar-deriv changed the title fix(deriv_rudderstack): [DERG-1502 ]Account sign up fix(analytics): [DERG-1502 ]Account sign up May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants