Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: [DSEC-25506] Fix security issue in GitHub actions #532

Merged

Conversation

behnam-deriv
Copy link
Contributor

Clickup link: https://app.clickup.com/t/20696747/DSEC-25506

This PR contains the following changes:

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Developers Note (Optional)

Pre-launch Checklist (For PR creator)

As a creator of this PR:

  • ✍️ I have included clickup id and package/app_name in the PR title.
  • 👁️ I have gone through the code and removed any temporary changes (commented lines, prints, debug statements etc.).
  • ⚒️ I have fixed any errors/warnings shown by the analyzer/linter.
  • 📝 I have added documentation, comments and logging wherever required.
  • 🧪 I have added necessary tests for these changes.
  • 🔎 I have ensured all existing tests are passing.

Reviewers

@sahani-deriv

Pre-launch Checklist (For Reviewers)

As a reviewer I ensure that:

  • ✴️ This PR follows the standard PR template.
  • 🪩 The information in this PR properly reflects the code changes.
  • 🧪 All the necessary tests for this PR's are passing.

Pre-launch Checklist (For QA)

  • 👌 It passes the acceptance criteria.

Pre-launch Checklist (For Maintainer)

  • [MAINTAINER_NAME] I make sure this PR fulfills its purpose.

sahani-deriv and others added 24 commits February 29, 2024 15:51
* chore(release): publish packages

 - [email protected]+4
 - [email protected]

* [create-pull-request] automated change

---------

Co-authored-by: GitHub Actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: sahani-deriv <[email protected]>
* feat(deriv_auth): single entry

feat that adds a single entry to the auth package

* chore(deriv_auth): improve some imports

* chore(deriv_auth): change deriv-api to dev branch

change deriv_api to dev branch and package_info_plus to version 4

* feat(deriv_auth): adding login page to single entry

* feat(deriv_auth): single entry login and reset pass added

* feat(deriv_auth): single entry signup page

* chore: setting page fist attempt

* feat(deriv_auith): single entry setting page

* feat(deriv_auth): single entry reset password and merge conflicts

* chore(deriv_auth): code review comments add docs and minor changes

* chore(deriv_auth): change residence to userResidence

* doc(deriv_auth): single entry doc and fix error handling

* chore(deriv_auth): fixing the deriv reset pass layout test

* chore(deriv_auth): change navigation to signupPage in verifyemailpage
* chore(release): publish packages

 - [email protected]

* [create-pull-request] automated change

---------

Co-authored-by: GitHub Actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: sahani-deriv <[email protected]>
Copy link

@ritik-deriv ritik-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sahani-deriv sahani-deriv merged commit c088ab0 into deriv-com:master Mar 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants