Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deriv_widgetbook): add deriv widgetbook package #484

Merged
merged 26 commits into from
Mar 4, 2024

Conversation

sahani-deriv
Copy link
Contributor

@sahani-deriv sahani-deriv commented Feb 20, 2024

Clickup link: https://app.clickup.com/t/20696747/MOBC-817

This PR contains the following changes:

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Developers Note (Optional)

Pre-launch Checklist (For PR creator)

As a creator of this PR:

  • ✍️ I have included clickup id and package/app_name in the PR title.
  • 👁️ I have gone through the code and removed any temporary changes (commented lines, prints, debug statements etc.).
  • ⚒️ I have fixed any errors/warnings shown by the analyzer/linter.
  • 📝 I have added documentation, comments and logging wherever required.
  • 🧪 I have added necessary tests for these changes.
  • 🔎 I have ensured all existing tests are passing.

Reviewers

Pre-launch Checklist (For Reviewers)

As a reviewer I ensure that:

  • ✴️ This PR follows the standard PR template.
  • 🪩 The information in this PR properly reflects the code changes.
  • 🧪 All the necessary tests for this PR's are passing.

Pre-launch Checklist (For QA)

  • 👌 It passes the acceptance criteria.

Pre-launch Checklist (For Maintainer)

  • [MAINTAINER_NAME] I make sure this PR fulfills its purpose.

@sahani-deriv sahani-deriv marked this pull request as ready for review February 26, 2024 06:52
@sahani-deriv sahani-deriv changed the title add(deriv_widgetbook): add deriv widgetbook package feat(deriv_widgetbook): add deriv widgetbook package Feb 26, 2024
@bassam-deriv bassam-deriv self-requested a review February 26, 2024 07:34
packages/deriv_widgetbook/analysis_options.yaml Outdated Show resolved Hide resolved
packages/deriv_widgetbook/android/app/build.gradle Outdated Show resolved Hide resolved
packages/deriv_widgetbook/web/favicon.png Outdated Show resolved Hide resolved
packages/deriv_widgetbook/pubspec.yaml Outdated Show resolved Hide resolved
packages/deriv_widgetbook/pubspec.yaml Outdated Show resolved Hide resolved
packages/deriv_widgetbook/pubspec.yaml Outdated Show resolved Hide resolved
packages/deriv_widgetbook/lib/theme/colors_usecases.dart Outdated Show resolved Hide resolved
@horam-deriv
Copy link
Contributor

Screenshot 2024-02-27 at 2 14 47 PM @sahani-deriv is this expected?

@sahani-deriv
Copy link
Contributor Author

Screenshot 2024-02-27 at 2 14 47 PM @sahani-deriv is this expected?

Yes, as it is disabled state of the widget.

@bassam-deriv
Copy link
Contributor

@sahani-deriv please resolve the conflict.

@sahani-deriv
Copy link
Contributor Author

@bassam-deriv done!

sahani-deriv and others added 2 commits February 29, 2024 15:51
* chore(release): publish packages

 - [email protected]+4
 - [email protected]

* [create-pull-request] automated change

---------

Co-authored-by: GitHub Actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: sahani-deriv <[email protected]>
ahrar-deriv and others added 3 commits February 29, 2024 16:28
* feat(deriv_auth): single entry

feat that adds a single entry to the auth package

* chore(deriv_auth): improve some imports

* chore(deriv_auth): change deriv-api to dev branch

change deriv_api to dev branch and package_info_plus to version 4

* feat(deriv_auth): adding login page to single entry

* feat(deriv_auth): single entry login and reset pass added

* feat(deriv_auth): single entry signup page

* chore: setting page fist attempt

* feat(deriv_auith): single entry setting page

* feat(deriv_auth): single entry reset password and merge conflicts

* chore(deriv_auth): code review comments add docs and minor changes

* chore(deriv_auth): change residence to userResidence

* doc(deriv_auth): single entry doc and fix error handling

* chore(deriv_auth): fixing the deriv reset pass layout test

* chore(deriv_auth): change navigation to signupPage in verifyemailpage
* chore(release): publish packages

 - [email protected]

* [create-pull-request] automated change

---------

Co-authored-by: GitHub Actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: sahani-deriv <[email protected]>
@sahani-deriv sahani-deriv merged commit 76b68a6 into deriv-com:master Mar 4, 2024
2 checks passed
@sahani-deriv sahani-deriv deleted the deriv_widgetbook branch March 4, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants