-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(deriv_ui): [MOBC-740] move UI related packages to deriv_ui #422
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this later needs to be moved to deriv_localizations
right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
I suggest we have one example app for all the ui components. For example we might have a list of components name and when we click on it we can view the component or something like this. If we all agree, this might be a work for another sprint. |
think it is best we re-arrange the structure as we now have multiple widgets in different categories. so the top folder should not be presentation/widgets. we should move all one level up and each category has its own presentation layer with widgets inside and core .... |
Yes I agree. Gradually this is what we want to achieve. to have a single example app to showcase all the UI components. |
I created a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about moving these to docs folder and linking it in the main readme?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest we keep it in the same folder as it will be easier for clients to find the relevant files of the README they are reading. for general docs we can move it to docs folder.
/// Extension for [BuildContext] to get localization. | ||
extension ContextExtension on BuildContext { | ||
/// Get localization. | ||
DateRangeLocalizations? get localization => DateRangeLocalizations.of(this); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think later we should use one localization class for all the components.
Clickup link: https://app.clickup.com/t/20696747/MOBC-740
This PR contains the following changes:
deriv_banner
toderiv_ui
deriv_date_range_picker
toderiv_ui
deriv_expandable_bottom_sheet
toderiv_ui
deriv_ui
and including the example app of above packages in itderiv_ui
Pre-launch Checklist (For PR creator)
As a creator of this PR:
Reviewers
@ahrar-deriv @sahani-deriv
Pre-launch Checklist (For Reviewers)
As a reviewer I ensure that:
Pre-launch Checklist (For QA)
Pre-launch Checklist (For Maintainer)