Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(deriv_web_view): updated flutter_inappwebview to 6.0.0 #390

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

bassam-deriv
Copy link
Contributor

@bassam-deriv bassam-deriv commented Jan 3, 2024

Clickup link: https://app.clickup.com/t/20696747/MOBC-703

This PR contains the following changes:

  • ✨ New feature (non-breaking change which adds functionality)
  • πŸ› οΈ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • βœ… Build configuration change
  • πŸ“ Documentation
  • πŸ—‘οΈ Chore

Pre-launch Checklist (For PR creator)

As a creator of this PR:

  • ✍️ I have included clickup id and package/app_name in the PR title.
  • πŸ‘οΈ I have gone through the code and removed any temporary changes (commented lines, prints, debug statements etc.).
  • βš’οΈ I have fixed any errors/warnings shown by the analyzer/linter.
  • πŸ”Ž I have ensured all existing tests are passing.

Reviewers

@behnam-deriv

Pre-launch Checklist (For Reviewers)

As a reviewer I ensure that:

  • ✴️ This PR follows the standard PR template.
  • πŸͺ© The information in this PR properly reflects the code changes.
  • πŸ§ͺ All the necessary tests for this PR's are passing.

Pre-launch Checklist (For QA)

  • πŸ‘Œ It passes the acceptance criteria.

Pre-launch Checklist (For Maintainer)

@behnam-deriv
Copy link
Contributor

Do these changes require to update readme file ?

@bassam-deriv
Copy link
Contributor Author

Do these changes require to update readme file ?

@behnam-deriv they don't because the changes does not affect any of the implementations in the client apps.

@ahrar-deriv ahrar-deriv merged commit 48f2be4 into deriv-com:master Jan 5, 2024
6 checks passed
@ahrar-deriv ahrar-deriv deleted the update_deriv_web_view branch January 5, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants