-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: [MOBC-701] [MOBC-702] combine deriv_auth_ui with deriv_auth and remove deriv_auth_ui #388
refactor!: [MOBC-701] [MOBC-702] combine deriv_auth_ui with deriv_auth and remove deriv_auth_ui #388
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahrar-deriv I suggest that we just merge this PR for now since it doesn't contain any actual changes to the code and all we did was move everything from deriv_auth_ui to deriv_auth which is technically not a breaking change so no need to keep it opened. Next we create a new PR which contains the actual refactoring of the package which will actually have creaking changes.
I do suggest though to rename the PR from refactor
to feat
since we're moving a whole feature (the UI) to this package just for the sake of properly versioning it once this PR is merged.
@ahrar-deriv right now |
@ahrar-deriv Why did you add ! to the PR title? |
need to bump the major as this is adding a new package ( feat ) in and removing another package, so it is easier to spot in versions also (in tags) |
…ges into combine_ui_with_auth # Conflicts: # README.md # packages/deriv_auth_ui/CHANGELOG.md # packages/deriv_auth_ui/pubspec.yaml
Clickup link:
https://app.clickup.com/t/20696747/MOBC-701
https://app.clickup.com/t/20696747/MOBC-702
This PR contains the following changes:
Pre-launch Checklist (For PR creator)
As a creator of this PR:
Reviewers
@bassam-deriv @behnam-deriv @ernest-deriv
Pre-launch Checklist (For Reviewers)
As a reviewer I ensure that:
Pre-launch Checklist (For QA)
Pre-launch Checklist (For Maintainer)