Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: replace contains with startsWith in versioning workflow #376

Merged
merged 3 commits into from
Dec 22, 2023

Conversation

sahani-deriv
Copy link
Contributor

@sahani-deriv sahani-deriv commented Dec 22, 2023

Clickup link:
Fixes issue: #

This PR contains the following changes:

  • ✨ New feature (non-breaking change which adds functionality)
  • πŸ› οΈ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • βœ… Build configuration change
  • πŸ“ Documentation
  • πŸ—‘οΈ Chore

Developers Note (Optional)

This change is because add can be used anywhere if not prefix so contains will make the versioning workflow not run if add is used in PR title. startsWith will be better.

Pre-launch Checklist (For PR creator)

As a creator of this PR:

  • ✍️ I have included clickup id and package/app_name in the PR title.
  • πŸ‘οΈ I have gone through the code and removed any temporary changes (commented lines, prints, debug statements etc.).
  • βš’οΈ I have fixed any errors/warnings shown by the analyzer/linter.
  • πŸ“ I have added documentation, comments and logging wherever required.
  • πŸ§ͺ I have added necessary tests for these changes.
  • πŸ”Ž I have ensured all existing tests are passing.

Reviewers

Pre-launch Checklist (For Reviewers)

As a reviewer I ensure that:

  • ✴️ This PR follows the standard PR template.
  • πŸͺ© The information in this PR properly reflects the code changes.
  • πŸ§ͺ All the necessary tests for this PR's are passing.

Pre-launch Checklist (For QA)

  • πŸ‘Œ It passes the acceptance criteria.

Pre-launch Checklist (For Maintainer)

  • [sahani] I make sure this PR fulfills its purpose.

@sahani-deriv
Copy link
Contributor Author

Merging with approval as without this versioning workflow doesn't work with PRs with add in title. Anas PR is blocked from versioning.

@sahani-deriv sahani-deriv merged commit 8bb1da4 into deriv-com:master Dec 22, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant