Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deriv_localizations): [MOBC-669] Added the localizations package. #370

Merged
merged 20 commits into from
Jan 9, 2024

Conversation

bassam-deriv
Copy link
Contributor

@bassam-deriv bassam-deriv commented Dec 19, 2023

Clickup link: https://app.clickup.com/t/20696747/MOBC-669

This PR contains the following changes:

Added deriv_localizations package which will contain all the localizations for flutter_deriv_packages along with the automation workflow of generating the dart files after crowdin's PR gets merged.

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Pre-launch Checklist (For PR creator)

As a creator of this PR:

  • ✍️ I have included clickup id and package/app_name in the PR title.
  • 👁️ I have gone through the code and removed any temporary changes (commented lines, prints, debug statements etc.).
  • ⚒️ I have fixed any errors/warnings shown by the analyzer/linter.
  • 📝 I have added documentation, comments and logging wherever required.

Reviewers

@sahani-deriv @ahrar-deriv

Pre-launch Checklist (For Reviewers)

As a reviewer I ensure that:

  • ✴️ This PR follows the standard PR template.
  • 🪩 The information in this PR properly reflects the code changes.
  • 🧪 All the necessary tests for this PR's are passing.

Pre-launch Checklist (For Maintainer)

packages/deriv_localizations/pubspec.yaml Outdated Show resolved Hide resolved
.github/workflows/localization.yml Outdated Show resolved Hide resolved
.github/workflows/localization.yml Outdated Show resolved Hide resolved
.github/workflows/localization.yml Outdated Show resolved Hide resolved
.github/workflows/localization.yml Outdated Show resolved Hide resolved
.github/workflows/localization.yml Outdated Show resolved Hide resolved
.github/workflows/localization.yml Outdated Show resolved Hide resolved
.github/workflows/localization.yml Outdated Show resolved Hide resolved
@ahrar-deriv ahrar-deriv merged commit 278d338 into deriv-com:master Jan 9, 2024
3 checks passed
@ahrar-deriv ahrar-deriv deleted the deriv_localizations branch January 9, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants