Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert(analytics): Revert versioning #355

Merged
merged 6 commits into from
Dec 8, 2023

Conversation

bassam-deriv
Copy link
Contributor

@bassam-deriv bassam-deriv commented Dec 8, 2023

Clickup link:
Fixes issue: #

This PR contains the following changes:

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Developers Note (Optional)

Pre-launch Checklist (For PR creator)

As a creator of this PR:

  • ✍️ I have included clickup id and package/app_name in the PR title.
  • 👁️ I have gone through the code and removed any temporary changes (commented lines, prints, debug statements etc.).
  • ⚒️ I have fixed any errors/warnings shown by the analyzer/linter.
  • 📝 I have added documentation, comments and logging wherever required.
  • 🧪 I have added necessary tests for these changes.
  • 🔎 I have ensured all existing tests are passing.

Reviewers

Pre-launch Checklist (For Reviewers)

As a reviewer I ensure that:

  • ✴️ This PR follows the standard PR template.
  • 🪩 The information in this PR properly reflects the code changes.
  • 🧪 All the necessary tests for this PR's are passing.

Pre-launch Checklist (For QA)

  • 👌 It passes the acceptance criteria.

Pre-launch Checklist (For Maintainer)

  • [sahani] I make sure this PR fulfills its purpose.

bassam-deriv and others added 6 commits May 19, 2023 13:16
merge regent markets dev branch
- Introduced a flexible configuration system to support multiple analytics providers.
- Added `BaseAnalyticsConfiguration` interface for standardizing analytics configuration.
- Internalized and restructured Datadog analytics by providing a `DerivDatadog` class that implements `BaseAnalytics<DerivDatadogConfiguration>`.
- Refined existing analytics services to have their own classes implementing `BaseAnalytics`.
- Introduced Enum types and extensions (`TrackingConsent`, `DatadogSite`) to aid in analytics configuration.
- Improved navigation observer support to work with multiple analytics providers.
- Enhanced exception handling to capture Flutter and Platform-specific errors.
- Added ability to set user information for analytics tracking.
- Replaced in-house Rudderstack plugin with the official Rudderstack SDK.

### Breaking changes:
**General**:
- `setup()` method for analytics providers now requires configuration classes implementing `BaseAnalyticsConfiguration`.
- Exception handling updated to include multiple analytics providers.
- Rudderstack: Now requires the official Rudderstack SDK for analytics. Update dependencies accordingly.
- Datadog: Migrated from a separate package to an internal implementation within this package.
- Existing analytics services have been restructured to implement `BaseAnalytics`, potentially changing function signatures and configurations.
@sahani-deriv sahani-deriv merged commit 81a3a0d into deriv-com:dev Dec 8, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants