Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update_auth_ui #314

Merged
merged 29 commits into from
Nov 20, 2023
Merged

feat: update_auth_ui #314

merged 29 commits into from
Nov 20, 2023

Conversation

sahani-deriv
Copy link
Contributor

@sahani-deriv sahani-deriv commented Oct 25, 2023 •
edited
Loading

Changes:

  • Update with latest deriv_auth.
  • Create flag for social login button panel.
  • Handle DerivAuthCubit listener in sign up layout.
  • Add app gesture detector in get started layout.
  • Add auth error state handler that can be reused in multiple pages that is dependent on DerivAuthCubit.
  • 485c839: Add consent check box for the countries that requires consent in signup flow.
  • 38a4c0e: fix forgot and change password flow.
  • 2f5185b: Refactor country selection cubit

@sahani-deriv sahani-deriv changed the title feat: update_auth_ui(Do not merge it yet) feat: update_auth_ui (Do not merge it yet) Oct 27, 2023
@sahani-deriv sahani-deriv changed the title feat: update_auth_ui (Do not merge it yet) feat: update_auth_ui Oct 31, 2023
sagar-deriv
sagar-deriv reviewed Nov 2, 2023
View reviewed changes
Copy link
Contributor

@sagar-deriv sagar-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some changes might needed. I have commented in the respective lines.

packages/deriv_auth_ui/example/pubspec.yaml Show resolved Hide resolved
packages/deriv_auth_ui/lib/src/features/signup/cubits/deriv_country_selection_state.dart Outdated Show resolved Hide resolved
packages/deriv_auth_ui/pubspec.yaml Show resolved Hide resolved
packages/deriv_auth_ui/lib/src/core/states/auth_error_state_mapper.dart Show resolved Hide resolved
sagar-deriv
sagar-deriv previously approved these changes Nov 10, 2023
View reviewed changes
@ahrar-deriv ahrar-deriv merged commit b2c282e into deriv-com:dev Nov 20, 2023
1 of 2 checks passed
@sahani-deriv sahani-deriv deleted the auth-ui-update branch November 29, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emad-deriv emad-deriv emad-deriv approved these changes

@ahrar-deriv ahrar-deriv ahrar-deriv approved these changes

@sagar-deriv sagar-deriv sagar-deriv left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sahani-deriv @ahrar-deriv @emad-deriv @sagar-deriv