-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [DRGO - 76] Adding subscription for crypto estimations #335
Open
ernest-deriv
wants to merge
3
commits into
deriv-com:master
Choose a base branch
from
ernest-deriv:Ernest/update_crypto_estimations
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57 changes: 57 additions & 0 deletions
57
lib/api/response/crypto_estimations_response_extended.dart
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
import 'package:deriv_dependency_injector/dependency_injector.dart'; | ||
import 'package:flutter_deriv_api/api/exceptions/base_api_exception.dart'; | ||
import 'package:flutter_deriv_api/api/models/base_exception_model.dart'; | ||
import 'package:flutter_deriv_api/api/response/crypto_estimations_response_result.dart'; | ||
import 'package:flutter_deriv_api/basic_api/generated/crypto_estimations_receive.dart'; | ||
import 'package:flutter_deriv_api/basic_api/generated/crypto_estimations_send.dart'; | ||
import 'package:flutter_deriv_api/basic_api/generated/forget_receive.dart'; | ||
import 'package:flutter_deriv_api/basic_api/response.dart'; | ||
import 'package:flutter_deriv_api/helpers/miscellaneous_helper.dart'; | ||
import 'package:flutter_deriv_api/services/connection/api_manager/base_api.dart'; | ||
import 'package:flutter_deriv_api/services/connection/call_manager/base_call_manager.dart'; | ||
|
||
/// Extended functionality for [CryptoEstimationsResponse] class. | ||
|
||
class CryptoEstimationsResponseExtended extends CryptoEstimationsResponse { | ||
static final BaseAPI _api = Injector()<BaseAPI>(); | ||
|
||
/// This will subscribe to crypto estimations.<br> | ||
/// Inside [CryptoEstimationsRequest] class: | ||
/// Incase of error, It will throw [BaseAPIException]. | ||
static Stream<CryptoEstimationsResponse?> subscribeToCryptoEstimates( | ||
CryptoEstimationsRequest request, { | ||
RequestCompareFunction? comparePredicate, | ||
}) => | ||
_api | ||
.subscribe(request: request, comparePredicate: comparePredicate)! | ||
.map<CryptoEstimationsResponse?>( | ||
(Response response) { | ||
checkException( | ||
response: response, | ||
exceptionCreator: ({BaseExceptionModel? baseExceptionModel}) => | ||
BaseAPIException(baseExceptionModel: baseExceptionModel), | ||
); | ||
|
||
if (response is CryptoEstimationsReceive) { | ||
return CryptoEstimationsResponse.fromJson( | ||
response.cryptoEstimations, response.subscription); | ||
} else { | ||
throw Exception('Bad response received'); | ||
} | ||
}, | ||
); | ||
|
||
/// unsubscribe from the subscribed Crypto Estimates <br> | ||
/// In case of error, It will throw [BaseAPIException]. | ||
static Future<bool> unsubscribeFromCryptoEstimates( | ||
String subscriptionId) async { | ||
final ForgetReceive response = | ||
await _api.unsubscribe(subscriptionId: subscriptionId); | ||
checkException( | ||
response: response, | ||
exceptionCreator: ({BaseExceptionModel? baseExceptionModel}) => | ||
BaseAPIException(baseExceptionModel: baseExceptionModel), | ||
); | ||
return response.forget!; | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you check if there is another reason for this issue? anyways, we should use actions from the approved list https://security.deriv.dev/github-action-scanner/exceptions/approved_actions.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure @abedelaziz-deriv
Will check on this.