Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passed authorize data through AuthDataContext #85

Merged

Conversation

hasan-deriv
Copy link
Contributor

@hasan-deriv hasan-deriv commented Oct 17, 2024

  • Authorized data is now passed through AuthDataContext, making it accessible via const { data } = useAuthData();.

This feature was requested by the bot team. Since useAuthorize hook can only be called once and is already used in AuthDataContext, we need to pass its data to make it accessible later.

Copy link
Contributor

@amam-deriv amam-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the approach, though please add more context on the description on why this changes is required, and if needed add the relevant test case to it

@shayan-deriv shayan-deriv merged commit df53650 into deriv-com:master Oct 21, 2024
1 check passed
Copy link

🎉 This PR is included in version 1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants