Integrate auth-client for Hydra logout functionality #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
adrienne-deriv
requested review from
azmib-developer,
ali-hosseini-deriv,
sandeep-deriv and
shafin-deriv
as code owners
thisyahlen-deriv
approved these changes
Oct 2, 2024
|
@adrienne-deriv is attempting to deploy a commit to the Deriv Team on Vercel. A member of the Team first needs to authorize it. |
thisyahlen-deriv
approved these changes
Oct 2, 2024
thisyahlen-deriv
approved these changes
Oct 2, 2024
thisyahlen-deriv
approved these changes
Oct 2, 2024
sandeep-deriv
approved these changes
Oct 2, 2024
adrienne-deriv
commented
Oct 2, 2024
| @@ -14,9 +14,6 @@ inputs: | |||
| GROWTHBOOK_CLIENT_KEY: | |||
| description: Growthbook client key for analytics | |||
| required: false | |||
| GROWTHBOOK_DECRYPTION_KEY: | |||
| description: Growthbook decryption key for analytics | |||
| required: false | |||
There was a problem hiding this comment.
GROWTHBOOK_DECRYPTION_KEY is not needed in the new analytics package update, thus removing it
amam-deriv
reviewed
Oct 2, 2024
| @@ -1,6 +1,6 @@ | |||
| import { useEffect, useState } from 'react'; | |||
| import { Analytics } from '@deriv-com/analytics'; | |||
| import useIsGrowthbookIsLoaded from './useIsGrowthbookLoaded'; | |||
| import useIsGrowthbookIsLoaded from '../useIsGrowthbookLoaded'; | |||
There was a problem hiding this comment.
is this changes intended?
There was a problem hiding this comment.
Yes, previously it was a file in src/hooks/useGrowthbookGetFeatureValue.tsx, moved it to a folder for consistency with other hooks
amam-deriv
approved these changes
Oct 2, 2024
prince-deriv
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Hydra authentication feature for
deriv-api-docsunder the feature flaghydra_be, this feature will allow SSO to be integrated toapi.deriv.com