Ahmed/dapi 715/chore resolve dashboard UI flow #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ahmed/DAPI-715/chore--resolve-dashboard-ui-flow
… ahmed/DAPI-715/chore--resolve-dashboard-ui-flow
ahmed-deriv
requested review from
azmib-developer,
ali-hosseini-deriv,
sandeep-deriv and
shafin-deriv
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -20,7 +20,7 @@ export default function ApiExplorerFeatures() { | |||
| const has_info = Object.keys(request_info).length === 0; | |||
There was a problem hiding this comment.
Can we rename the folder Apiexplorer to ApiExplorer?
There was a problem hiding this comment.
@prince-deriv Yes, We can but this will add more file changes due to folder name changes which I think we shouldn't do that we can't do it later.
| } | ||
|
|
||
| .dropdown__link--active { | ||
| color: var(--core-color-opacity-black-600, rgba(0, 0, 0, 0.72)) !important; | ||
| color: var(--colors-coral500) !important; |
There was a problem hiding this comment.
--colors-coral500 is this a quill token variable?
There was a problem hiding this comment.
then this is incorrect. We only have these coral tokens:
--core-color-solid-coral-500
--core-color-opacity-coral-500
prince-deriv
approved these changes
Sep 25, 2024
prince-deriv
merged commit d3b8f01
into
deriv-com:feature/new-dashboard--1
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.