fix: removing extra divs, fixing styling on 2 tabs, everything in quill #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrim-deriv
requested review from
azmib-developer,
ali-hosseini-deriv,
sandeep-deriv and
shafin-deriv
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ahmed-deriv
suggested changes
Sep 20, 2024
There was a problem hiding this comment.
Is it only UI changes or logics changes as well ?
| button { | ||
| margin-inline: 8px; | ||
| } | ||
| gap: rem(0.8); | ||
| } | ||
|
|
||
| .mblk { |
There was a problem hiding this comment.
can you create root values and also create this style into global file to reuse this spacing on other pages/components if needed. Also use rem to all places as some have value in pixels and some have rem
prince-deriv
approved these changes
Sep 26, 2024
sandeep-deriv
merged commit 58a5de7
into
deriv-com:feature/new-dashboard--1
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.