feat: Adding the trackerror message method to pass to the event #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aswathy-deriv
requested review from
ali-hosseini-deriv and
prince-deriv
as code owners
prince-deriv
reviewed
Nov 8, 2024
Comment on lines
+84
to
+110
| //tracking the track js error | ||
|
|
||
| trackConsoleErrors = (): any => { | ||
| let latestErrorMessage: string | null = null | ||
| // Preserve the original console.error function | ||
| const originalConsoleError = console.error | ||
|
|
||
| // Override console.error to capture and handle errors | ||
| console.error = function (...args: unknown[]): any { | ||
| // Log the error to the console as usual | ||
| originalConsoleError.apply(console, args) | ||
|
|
||
| // Create a clean error message without __trackjs_state__ | ||
| const errorMessage = args | ||
| .map(arg => | ||
| arg && typeof arg === 'object' && 'message' in arg | ||
| ? (arg as Error).message | ||
| : typeof arg === 'object' | ||
| ? JSON.stringify(arg, (key, value) => (key.startsWith('__trackjs') ? undefined : value)) | ||
| : String(arg) | ||
| ) | ||
| .join(' ') | ||
| latestErrorMessage = errorMessage | ||
| return errorMessage | ||
| } | ||
| return latestErrorMessage | ||
| } |
There was a problem hiding this comment.
@Aswathy Menon we need to add this in cacheTrackEvents instead if we want to capture all errors. Also this function won't work you are returning the message but it will always be empty, it will only have value when error occurs but when that happened you won't get the hold of the value anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.