Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: TokenInfo를 record로 변경하고 token-value 부분을 받도록 수정한다 #407

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

devxb
Copy link
Member

@devxb devxb commented Mar 10, 2024

#406
이거 리뷰 수정 내용입니다
PR이 main -> release라 열려있는 PR때문에 main에 push하면 바로 배포되서 branch따로 만들었어요

Copy link

Copy link
Member

@dojinyou dojinyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

내가 생각한 건 decryptToken 자체를 인터셉터에서 하고 LoginedInfo를 넘겨주면 좋을 것 같은데

@devxb
Copy link
Member Author

devxb commented Mar 11, 2024

내가 생각한 건 decryptToken 자체를 인터셉터에서 하고 LoginedInfo를 넘겨주면 좋을 것 같은데

애매한게, 지금 의존성이 auth -> user 이고 auth-interceptor는 모든 인증 필요 패스에 인증값 넣어주는거라 이 방향으로 가면 LoginedInfo 정의 위치가 좀 애매하달까..

@dojinyou
Copy link
Member

auth에서 검증하는 부분은 user 참조하는거 없지 않아?

@devxb
Copy link
Member Author

devxb commented Mar 11, 2024

음 직접적으로 참조하고 있지는 않은데,

auth-interceptor -> auth-application -> user-application, user-domain

요렇게 참조하고있어.

@dojinyou
Copy link
Member

image 얘는 유저 의존성 없는데?

@devxb devxb merged commit 3988ace into main Mar 12, 2024
4 checks passed
@devxb devxb deleted the devxb/hotfix-api-email branch March 12, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants