Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] : login된 유저 조회 api가 email을 함께 반환하도록 수정 #401

Merged
merged 5 commits into from
Mar 8, 2024

Conversation

devxb
Copy link
Member

@devxb devxb commented Mar 8, 2024

어떤 기능을 개발했나요?

로그인된 유저 조회 api가 email을 함께 반환하도록 수정했습니다.
(아래 사진 페이지 조회시 필요)

스크린샷 2024-03-08 오후 5 22 34

어떻게 해결했나요?

  • jwt encoding시 payload에 email 추가
  • jwt decoding시 payload에서 email꺼내도록 수정
  • 반환 dto에 user email 추가
  • 기존 테스트 수정
  • e2e 테스트 추가

이슈 넘버

참고자료

@devxb devxb self-assigned this Mar 8, 2024
@devxb devxb changed the title refactor: login된 유저 조회 api가 email을 함께 반환하도록 수정 [refactor] : login된 유저 조회 api가 email을 함께 반환하도록 수정 Mar 8, 2024
Copy link
Member

@dojinyou dojinyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

사용자가 이메일을 수정할 경우, 즉각 반영이 안될 수 있을 것 같음

@devxb devxb requested a review from dojinyou March 8, 2024 10:28
Copy link

sonarqubecloud bot commented Mar 8, 2024

@devxb devxb merged commit 1ffe225 into main Mar 8, 2024
4 checks passed
@devxb devxb deleted the devxb/iss-#400 branch March 8, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[refactor] : 로그인된 유저 조회 API가 email을 함께 반환하도록 수정
2 participants