Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release]: 중복 survey생성을 막는다 #386

Merged
merged 6 commits into from
Mar 6, 2024

Conversation

devxb
Copy link
Member

@devxb devxb commented Mar 6, 2024

어떤 기능을 개발했나요?

Survey가 여러개 있을때, 최신 Survey를 반환하도록 수정

어떻게 해결했나요?

  • Jpa 쿼리 수정

참고자료

@devxb devxb self-assigned this Mar 6, 2024
Copy link
Member

@dojinyou dojinyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

지금 멀티 서베이 안되지 않나? 요거 바꾸는 이유를 모르겠음

@devxb devxb force-pushed the devxb/hotfix-unique-result-query branch from fba512d to 7bb89f7 Compare March 6, 2024 10:02
@devxb devxb requested a review from dojinyou March 6, 2024 10:04
Copy link
Member

@dojinyou dojinyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

생성할 때 조회하고 체크하는 로직이 있으면 좋겠음!

@devxb devxb force-pushed the devxb/hotfix-unique-result-query branch from 6082c77 to 3200ead Compare March 6, 2024 11:01
@@ -0,0 +1,8 @@
package me.nalab.survey.application.exception;

public class DuplicateSurveyException extends RuntimeException {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

에러 공통 있으면 그쪽에 제네릭으로 만들어도 될듯?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잘 이해가 안되는데, 좀 더 설명 plz

Copy link
Member

@dojinyou dojinyou Mar 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DuplicationException<Survey>(message) 이런 느낌으로 쓰면 좋겠다?

@devxb devxb changed the title [release]: getSurveyByTargetId가 항상 최신 Survey를 반환하도록 수정한다 [release]: 중복 survey생성을 방지한다 Mar 6, 2024
@devxb devxb changed the title [release]: 중복 survey생성을 방지한다 [release]: 중복 survey생성을 막는다 Mar 6, 2024
@devxb devxb merged commit e607a38 into release Mar 6, 2024
3 checks passed
@devxb devxb deleted the devxb/hotfix-unique-result-query branch March 6, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants