Skip to content

Commit

Permalink
build: App Version Target 1.2.5로 설정해요 (#731)
Browse files Browse the repository at this point in the history
* build: Tuist Project+Templates MARKETING_VERSION 1.2.5로 수정
- CFBundleShortVersionString 1.2.5로 수정
- Bundle+Ext App Key Property Value 1.2.5 Version으로 수정
- BBNetwork App Key Value 1.2.5 Version 으로 수정

* fix: AccountProfileViewController NotificationCenter 이벤트 중복 방출 코드 수정
  • Loading branch information
Do-hyun-Kim authored Dec 24, 2024
1 parent 4c8e7e1 commit 7bb1929
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 8 deletions.
2 changes: 1 addition & 1 deletion 14th-team5-iOS/App/Project.swift
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ private let targets: [Target] = [
"CFBundleDisplayName": .string("Bibbi"),
"CFBundleVersion": .string("1"),
"CFBuildVersion": .string("0"),
"CFBundleShortVersionString": .string("1.2.4"),
"CFBundleShortVersionString": .string("1.2.5"),
"UILaunchStoryboardName": .string("LaunchScreen"),
"UISupportedInterfaceOrientations": .array([.string("UIInterfaceOrientationPortrait")]),
"UIUserInterfaceStyle": .string("Dark"),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -229,10 +229,11 @@ extension AccountProfileViewController: PHPickerViewControllerDelegate {
let itemProvider = results.first?.itemProvider
picker.dismiss(animated: true)
if let imageProvider = itemProvider, imageProvider.canLoadObject(ofClass: UIImage.self) {
imageProvider.loadObject(ofClass: UIImage.self) { image, error in
guard let photoImage: UIImage = image as? UIImage,
imageProvider.loadObject(ofClass: UIImage.self) { [weak self] image, error in
guard let self = self,
let photoImage: UIImage = image as? UIImage,
let originalData: Data = photoImage.jpegData(compressionQuality: 1.0) else { return }
imageProvider.didSelectProfileImageWithProcessing(photo: originalData, error: error)
self.reactor?.action.onNext(.didTapPHAssetsImage(originalData))
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion 14th-team5-iOS/Core/Sources/Extensions/Bundle+Ext.swift
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,6 @@ extension Bundle {
}

public var xAppKey: String {
"da91623d-fe55-4115-8e14-aa7581761963"
"39d7cdd1-218c-4abd-addb-ab4efff8a369"
}
}
2 changes: 1 addition & 1 deletion 14th-team5-iOS/Core/Sources/Trash/BBNetwork/API.swift
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public enum BibbiAPI {
public var value: String {
switch self {
case let .auth(token): return "Bearer \(token)"
case .xAppKey: return "da91623d-fe55-4115-8e14-aa7581761963" // TODO: - 번들에서 가져오기
case .xAppKey: return "39d7cdd1-218c-4abd-addb-ab4efff8a369" // TODO: - 번들에서 가져오기
case let .xAuthToken(token): return "\(token)"
case .contentForm: return "application/x-www-form-urlencoded"
case .contentJson: return "application/json"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ extension AppRepository {

public func fetchAppVersion() -> Observable<AppVersionEntity> {
// TODO: - xAppKey 불러오는 코드 다시 작성하기
let appKey = "7b159d28-b106-4b6d-a490-1fd654ce40c2"
let appKey = "39d7cdd1-218c-4abd-addb-ab4efff8a369"

return meAPIWorker.fetchAppVersion(appKey: appKey)
.map { $0.toDomain() }
Expand Down
2 changes: 1 addition & 1 deletion Tuist/ProjectDescriptionHelpers/Project+Templates.swift
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ extension Project {
settings: .settings(
base: [
"OTHER_LDFLAGS": "$(inherited) -ObjC",
"MARKETING_VERSION": "1.2.4",
"MARKETING_VERSION": "1.2.5",
"CURRENT_PROJECT_VERSION": "1",
"VERSIONING_SYSTEM": "apple-generic"
],
Expand Down

0 comments on commit 7bb1929

Please sign in to comment.