Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Java 21 #420

Merged
merged 5 commits into from
Dec 11, 2024
Merged

chore: Java 21 #420

merged 5 commits into from
Dec 11, 2024

Conversation

char-yb
Copy link
Member

@char-yb char-yb commented Dec 10, 2024

๐ŸŒฑ ๊ด€๋ จ ์ด์Šˆ

๐Ÿ“Œ ์ž‘์—… ๋‚ด์šฉ ๋ฐ ํŠน์ด์‚ฌํ•ญ

  • Java 21์œผ๋กœ ๋ณ€๊ฒฝ
  • Spring boot 3.4.0 ๋ณ€๊ฒฝ
  • yml์— Virtual Thread ์‚ฌ์šฉํ•˜๋„๋ก ์˜ต์…˜ ์ถ”๊ฐ€
  • github workflow Java 21 ๋ฒ„์ „ ์‚ฌ์šฉ
  • DockerFile temurin 21 ๋ณ€๊ฒฝ
  • 21 ์‚ฌ์šฉ์— ๋”ฐ๋ผ Spring boot ver 3.4.0์œผ๋กœ migration
  • gradle version 8.10์œผ๋กœ ๋ณ€๊ฒฝ
  • Jacoco version๋„ gradle 8.10 ๋ณ€๊ฒฝ์œผ๋กœ ์ธํ•ด 0.8.12๋กœ ๋ณ€๊ฒฝ
  • Spotless 6.21.0์œผ๋กœ ๋ณ€๊ฒฝ
  • Generational ZGC ๋„์ž…

image

๐Ÿ“ ์ฐธ๊ณ ์‚ฌํ•ญ

  • 3.4.0์œผ๋กœ ๋ณ€๊ฒฝ ์ค‘ test ์ฝ”๋“œ์—์„œ MockBean ์–ด๋…ธํ…Œ์ด์…˜์ด Deprecated ๋จ์œผ๋กœ MockitoBean ์‚ฌ์šฉ
  • ์ฒ˜๋ฆฌ๋Ÿ‰ ์ธก๋ฉด์—์„œ, Generational ZGC๋Š” JDK 17์˜ ๋‹จ์ผ ์„ธ๋Œ€ ZGC ๋Œ€๋น„ ์•ฝ 10%์˜ ๊ฐœ์„ ์„ ๋ณด์˜€์ง€๋งŒ, ์•ฝ๊ฐ„์˜ ์ €ํ•˜๊ฐ€ ์žˆ์—ˆ๋˜ JDK 21์˜ ๋‹จ์ผ ์„ธ๋Œ€ ZGC ๋Œ€๋น„ ์•ฝ 10% ์ด์ƒ์˜ ์„ฑ๋Šฅ ํ–ฅ์ƒ์„ ๋ณด์˜€๋‹ค๊ณ  ํ•œ๋‹ค

๐Ÿ“š ๊ธฐํƒ€

@char-yb char-yb added ๐Ÿฅ‰ P3 ๊ธ‰ํ•˜์ง€ ์•Š์€ ์ด์Šˆ โ™ป๏ธ refactor ๊ธฐ๋Šฅ ๊ฐœ์„  โš™๏ธ chore ๋นŒ๋“œ ๋ฐ CI/CD labels Dec 10, 2024
@char-yb char-yb self-assigned this Dec 10, 2024
@char-yb char-yb linked an issue Dec 10, 2024 that may be closed by this pull request
@char-yb char-yb changed the title Java 21 chore: Java 21 version Dec 10, 2024
@char-yb char-yb changed the title chore: Java 21 version chore: Java 21 Dec 10, 2024
Copy link
Member

@uwoobeat uwoobeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ตฟ์ด์—์š”
์ถ”๊ฐ€๋กœ Generational ZGC ํ‚ค์›Œ๋“œ๋กœ๋„ ์ฐพ์•„๋ณด์‹œ๊ฒ ์–ด์š”?
Java 21 ๋„์ž…ํ•œ๋‹ค๋ฉด ๊ฒ€ํ† ํ•ด๋ณผ๋งŒํ•œ ๋ถ€๋ถ„์ด๋ผ๊ณ  ๋ด…๋‹ˆ๋‹ค.

Dockerfile Outdated
@@ -1,4 +1,4 @@
FROM eclipse-temurin:17
FROM eclipse-temurin:21
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ทธ๋ฆฌ๊ณ  ์ €ํฌ aws๋กœ ์ด์ „ํ•˜๊ณ  ๋‚˜์„œ os๋กœ al2023์„ ์‚ฌ์šฉํ•˜๊ณ  ์žˆ์œผ๋‹ˆ, amazon corretto jdk๋ฅผ ์‚ฌ์šฉํ•˜๋Š”๋ฐ ๋” ์ข‹์„ ๊ฒƒ ๊ฐ™์•„์š”.
++ ์ด๋ฏธ์ง€ ํฌ๊ธฐ๋„ ์ค„์ผ ๊ฒธ alpine์œผ๋กœ ๋ณ€๊ฒฝํ•˜๋ฉด ๋” ์ข‹๊ณ ์š”.

โœ… Recommendation: Corretto builds are a good choice, particularly if you run Java applications directly on Amazon Linux 2 in AWS. ๋ ˆํผ๋Ÿฐ์Šค

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋™์˜ํ•ฉ๋‹ˆ๋‹น๐Ÿ‘
corretto jdk ๋ฒ„์ „ ํ™•์ธ ํ›„ ์ ์šฉํ•ด๋ณผ๊ฒŒ์šฉ

Copy link
Member

@uwoobeat uwoobeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@char-yb char-yb merged commit 3ce8a82 into develop Dec 11, 2024
3 checks passed
@github-actions github-actions bot added the merged ๋จธ์ง€๋œ PR label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
โš™๏ธ chore ๋นŒ๋“œ ๋ฐ CI/CD merged ๋จธ์ง€๋œ PR ๐Ÿฅ‰ P3 ๊ธ‰ํ•˜์ง€ ์•Š์€ ์ด์Šˆ โ™ป๏ธ refactor ๊ธฐ๋Šฅ ๊ฐœ์„ 
Projects
Status: ์™„๋ฃŒ
Development

Successfully merging this pull request may close these issues.

โš™๏ธ Java 21 ๋„์ž…
2 participants