Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Object Storage -> AWS S3 Bucket 으로 변경 #395

Merged
merged 2 commits into from
May 15, 2024
Merged

chore: Object Storage -> AWS S3 Bucket 으로 변경 #395

merged 2 commits into from
May 15, 2024

Conversation

char-yb
Copy link
Member

@char-yb char-yb commented May 15, 2024

🌱 관련 이슈

📌 작업 내용 및 특이사항

  • StorageConfig 네이밍을 S3로 변경
  • 환경 변수 네이밍도 STORAGE에서 AWS 또는 AWS S3로 변경

📝 참고사항

📚 기타

@char-yb char-yb added the ⚙️ chore 빌드 및 CI/CD label May 15, 2024
@char-yb char-yb self-assigned this May 15, 2024
@char-yb char-yb requested review from kdomo and uwoobeat as code owners May 15, 2024 14:43
@char-yb char-yb linked an issue May 15, 2024 that may be closed by this pull request
⚙️ Object Storage -> AWS S3 Bucket #394
Closed
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
207 New issues
0 Accepted issues

Measures
0 Security Hotspots
48.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

kdomo
kdomo approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@kdomo kdomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅LGTM✅

@char-yb char-yb merged commit fd3649a into develop May 15, 2024
2 checks passed
@github-actions github-actions bot added the merged 머지된 PR label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdomo kdomo kdomo approved these changes

@uwoobeat uwoobeat Awaiting requested review from uwoobeat uwoobeat is a code owner

Assignees

@char-yb char-yb

Labels
⚙️ chore 빌드 및 CI/CD merged 머지된 PR
Projects
10mm-server
Status: 완료
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

⚙️ Object Storage -> AWS S3 Bucket
2 participants
@char-yb @kdomo