feat: 알림을 확인 할 수 있는 알림센터 기능 추가 #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
char-yb
reviewed
May 8, 2024
Comment on lines
+8
to
+16
| public record NotificationFindAllResponse( | ||
| @Schema(description = "알림 타입") NotificationType notificationType, | ||
| @Schema(description = "알림 날짜") LocalDateTime createdAt) { | ||
|
|
||
| public static NotificationFindAllResponse of( | ||
| NotificationType notificationType, LocalDateTime createdAt) { | ||
| return new NotificationFindAllResponse(notificationType, createdAt); | ||
| } | ||
| } |
There was a problem hiding this comment.
notificationType과 createdAt만 DTO로 정하신 이유가 있나요??
source나 targetId로 필요한 데이터가 있지 않을까해서용
There was a problem hiding this comment.
알림에 대한 후속 액션이 없고
단순 뷰로 보여주기위한 기획이여서
요대로 작성했숨니당
kdomo
force-pushed
the
feature/365-notification
branch
from
ea532fa to
1798660
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌱 관련 이슈
📌 작업 내용 및 특이사항
📚 기타