Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fcm 토큰이 빈 값이라면 푸시 알림을 보내지 않도록 설정 #279

Merged
merged 1 commit into from
Feb 6, 2024
Merged

fix: fcm 토큰이 빈 값이라면 푸시 알림을 보내지 않도록 설정 #279

merged 1 commit into from
Feb 6, 2024

Conversation

kdomo
Copy link
Member

@kdomo kdomo commented Feb 6, 2024 •
edited
Loading

🌱 관련 이슈

📌 작업 내용 및 특이사항

  • 현재 fcm 토큰 값이 null이거나, 다른 공백 값으로 채웠을 때 푸시알림을 보낸다면 아래와 같은 에러 발생
    Exactly one of token, topic or condition must be specified
image - 토큰이 빈값일 때 보내지 않도록 설정

@kdomo kdomo added the 🐛 bug/error 버그 및 에러 픽스 label Feb 6, 2024
@kdomo kdomo added this to the 3차 스프린트 milestone Feb 6, 2024
@kdomo kdomo self-assigned this Feb 6, 2024
char-yb
char-yb approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@char-yb char-yb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 6, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

70 New issues
0 Security Hotspots
47.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kdomo kdomo merged commit 434f2a4 into develop Feb 6, 2024
3 checks passed
@github-actions github-actions bot added the merged 머지된 PR label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@char-yb char-yb char-yb approved these changes

@uwoobeat uwoobeat Awaiting requested review from uwoobeat uwoobeat is a code owner

Assignees

@kdomo kdomo

Labels
🐛 bug/error 버그 및 에러 픽스 merged 머지된 PR
Projects
10mm-server
Status: 완료
Milestone
3차 스프린트
Development

Successfully merging this pull request may close these issues.

🐛 fcm 토큰이 빈 값이라면 푸시 알림을 보내지 않도록 설정
2 participants
@kdomo @char-yb