Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Swagger 버전 이미지 태그로 동적 추가 #184

Merged
merged 4 commits into from
Jan 21, 2024
Merged

feat: Swagger 버전 이미지 태그로 동적 추가 #184

merged 4 commits into from
Jan 21, 2024

Conversation

kdomo
Copy link
Member

@kdomo kdomo commented Jan 19, 2024

🌱 관련 이슈

📌 작업 내용 및 특이사항

  • 현재 Swagger에 버저닝이 0.0.1로 고정되어있는데 이를 워크플로에서 동적으로 추가하여 Swagger에서 볼 수 있도록 하려고합니다
  • SWAGGER_VERSION=${{ env.NCP_IMAGE_TAG }}를 통해 값을 담아두고,
    workflow에서 sed 명령을 통해 값을 업데이트 합니다
    .env 파일에서 SWAGGER_VERSION=.*으로 이루어진 행을 찾아 SWAGGER_VERSION=$SWAGGER_VERSION으로 업데이트 합니다

📝 참고사항

  • 서버에 SWAGGER_VERSION 환경변수 추가 완료
  • 환경 변수 없다면 defalut로 적용되도록 기본 값 설정

@kdomo kdomo added the ✨ feature 새로운 기능 추가 및 수정 label Jan 19, 2024
@kdomo kdomo added this to the 2.5차 스프린트 milestone Jan 19, 2024
@kdomo kdomo requested review from char-yb and uwoobeat January 19, 2024 09:45
@kdomo kdomo self-assigned this Jan 19, 2024
@kdomo kdomo added the 🥉 P3 급하지 않은 이슈 label Jan 19, 2024
char-yb
char-yb approved these changes Jan 20, 2024
View reviewed changes
Copy link
Member

@char-yb char-yb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kdomo kdomo force-pushed the feature/183-swagger-version-injection branch from eeafe98 to 187d015 Compare January 21, 2024 07:47
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

37 New issues
0 Security Hotspots
51.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kdomo kdomo merged commit ee90f5b into develop Jan 21, 2024
2 checks passed
@github-actions github-actions bot added the merged 머지된 PR label Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@char-yb char-yb char-yb approved these changes

@uwoobeat uwoobeat Awaiting requested review from uwoobeat uwoobeat is a code owner

Assignees

@kdomo kdomo

Labels
✨ feature 새로운 기능 추가 및 수정 merged 머지된 PR 🥉 P3 급하지 않은 이슈
Projects
10mm-server
Status: 완료
Milestone
2.5차 스프린트
Development

Successfully merging this pull request may close these issues.

✨ Swagger 버전 이미지 태그로 동적 추가
2 participants
@kdomo @char-yb