Skip to content

Commit

Permalink
handle errors in dep, correctly catch missing url in version check (#65)
Browse files Browse the repository at this point in the history
* handle errors in dep, correctly catch missing url in version check

replace console.error with throw to handle dep error failures
in main try/catch to mark job as failed in one place

* add test action, prevent failure on empty options

* fix conflict resolution
  • Loading branch information
piotrkwiecinski authored Mar 7, 2024
1 parent 373ff33 commit 6242095
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 2 deletions.
17 changes: 17 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
name: 'build-test'
on: # rebuild any PRs and main branch changes
pull_request:
push:
branches:
- master
- 'releases/*'

jobs:
test: # make sure the action works on a clean machine without building
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: ./
with:
dep: list
deployer-version: "7.3.0"
4 changes: 2 additions & 2 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,8 @@ async function dep() {
break
}
}
if (url === null) {
console.error(`The version "${version}"" does not exist in the "https://deployer.org/manifest.json" file."`)
if (typeof url === 'undefined') {
core.setFailed(`The version "${version}"" does not exist in the "https://deployer.org/manifest.json" file."`)
} else {
console.log(`Downloading "${url}".`)
await $`curl -LO ${url}`
Expand Down

0 comments on commit 6242095

Please sign in to comment.