Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

To support for "containerFiles" more robust #11145

Merged
merged 13 commits into from
Dec 18, 2024
Merged

To support for "containerFiles" more robust #11145

merged 13 commits into from
Dec 18, 2024

Conversation

randhircs
Copy link
Member

@randhircs randhircs commented Dec 17, 2024 •
edited
Loading

What are you trying to accomplish?

Some of the changes in the other PR are useful to make our support for "containerFiles" more robust. Here, copied the same to merge.

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

If it passes all the test cases added for containerfiles.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@randhircs randhircs requested a review from a team as a code owner December 17, 2024 20:29
@github-actions github-actions bot added the L: docker Docker containers label Dec 17, 2024
@randhircs randhircs force-pushed the randhircs/improved-code-containerfile-with-dockerfile branch from 6c9a5ff to 3ce0f86 Compare December 17, 2024 20:30
@randhircs randhircs self-assigned this Dec 17, 2024
@randhircs randhircs force-pushed the randhircs/improved-code-containerfile-with-dockerfile branch from 807e975 to 2e08911 Compare December 18, 2024 13:03
@randhircs randhircs merged commit ba0bbf8 into main Dec 18, 2024
56 checks passed
@randhircs randhircs deleted the randhircs/improved-code-containerfile-with-dockerfile branch December 18, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdulapopoola abdulapopoola abdulapopoola approved these changes

Assignees

@randhircs randhircs

Labels
L: docker Docker containers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@randhircs @abdulapopoola