-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python metric collection #11013
Python metric collection #11013
Conversation
nil | ||
end | ||
|
||
sig { returns(T.any(String, T.untyped)) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why return untyped
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abdulapopoola , This is for fail safe , As we are extracting package manager version from shell command, in case the output changes or there is any issue in version extraction (very low possibility) we can make sure metric collection exception does not cause update to fail. We are checking for untyped at "return PoetryPackageManager.new(detect_poetry_version) if poetry_files && detect_poetry_version"
77aef56
to
8d55982
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7ff7c2c
to
c78c833
Compare
What are you trying to accomplish?
Fix: Enables metric collection for
pip-compile
andpipenv
Enhancements to package manager detection:
Also enables local python setup for correct detection of
pip-compile
,poetry
andpipenv
based of python versionAnything you want to highlight for special attention from reviewers?
How will you know you've accomplished your goal?
Checklist