gracefully exit if we can't solve an issue with peer dependencies #11000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettfo
force-pushed
the
dev/brettfo/nuget-peer-dependencies
branch
from
2383854
to
6df0c9b
Compare
sebasgomez238
approved these changes
Nov 22, 2024
brettfo
force-pushed
the
dev/brettfo/nuget-peer-dependencies
branch
2 times, most recently
from
0476d96
to
32bfa70
Compare
randhircs
force-pushed
the
dev/brettfo/nuget-peer-dependencies
branch
from
32bfa70
to
1b870a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to perform an update, we currently can't do it if we detect a difference in the peer dependencies. Eventually this is a situation that should be solvable, but since it's currently not, it's better to gracefully exit the updater instead of throwing an error.
This is currently one of the biggest error traces in the telemetry.