Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables python ecosystem metric collection #10986

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

sachin-sandhu
Copy link
Contributor

@sachin-sandhu sachin-sandhu commented Nov 21, 2024

What are you trying to accomplish?

Adds metric collection for python ecosystem

This PR is for enabling Python ecosystem metric collection

Collects:
Ecosystem : Poetry (pending(updated) : pip, pip-compile, pipenv)
Language
Raw version

Pending:
Package constraint
Min/Max versions

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@sachin-sandhu sachin-sandhu self-assigned this Nov 21, 2024
@sachin-sandhu sachin-sandhu marked this pull request as ready for review November 21, 2024 23:09
@sachin-sandhu sachin-sandhu requested a review from a team as a code owner November 21, 2024 23:09
Copy link
Contributor

@pavera pavera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this captures anything for pip-compile or pipenv? As I'm reading it, it will report anything other than poetry as pip?

@sachin-sandhu
Copy link
Contributor Author

I'm not sure this captures anything for pip-compile or pipenv? As I'm reading it, it will report anything other than poetry as pip?

@pavera , yes you are right, it would be done next week, right now we are focusing on sending one of version metric and see everything is working fine.

def detected_package_manager
return PeotryPackageManager.new(detect_poetry_version) if poetry_lock && detect_poetry_version

PipPackageManager.new(DEFAULT_PACKAGE_MANAGER_VERSION)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you already noted but just want mentioned it. You are going to get pip manager version by running command here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kbukum1 , i updated to extract version from shell command

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants