-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enables python ecosystem metric collection #10986
base: main
Are you sure you want to change the base?
Enables python ecosystem metric collection #10986
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this captures anything for pip-compile or pipenv? As I'm reading it, it will report anything other than poetry as pip?
@pavera , yes you are right, it would be done next week, right now we are focusing on sending one of version metric and see everything is working fine. |
def detected_package_manager | ||
return PeotryPackageManager.new(detect_poetry_version) if poetry_lock && detect_poetry_version | ||
|
||
PipPackageManager.new(DEFAULT_PACKAGE_MANAGER_VERSION) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you already noted but just want mentioned it. You are going to get pip manager version by running command here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kbukum1 , i updated to extract version from shell command
What are you trying to accomplish?
Adds metric collection for python ecosystem
This PR is for enabling Python ecosystem metric collection
Collects:
Ecosystem : Poetry (pending(updated) : pip, pip-compile, pipenv)
Language
Raw version
Pending:
Package constraint
Min/Max versions
Anything you want to highlight for special attention from reviewers?
How will you know you've accomplished your goal?
Checklist