Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a flaky test #234

Merged
merged 1 commit into from
Jan 17, 2024
Merged

fix a flaky test #234

merged 1 commit into from
Jan 17, 2024

Conversation

jakecoffman
Copy link
Member

@jakecoffman jakecoffman commented Jan 12, 2024

Similar to #198, by starting a listener first we ensure there isn't a need to wait or retry. It also selects any available port.

@jakecoffman jakecoffman requested a review from a team as a code owner January 12, 2024 16:02
@jakecoffman jakecoffman enabled auto-merge January 12, 2024 16:05
@jakecoffman jakecoffman added this pull request to the merge queue Jan 17, 2024
Merged via the queue into main with commit 62f8e6a Jan 17, 2024
69 checks passed
@jakecoffman jakecoffman deleted the fix-a-flake branch January 17, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants