-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow running OpenTelemetry collector #181
Merged
jakecoffman
merged 5 commits into
dependabot:main
from
JamieMagee:jamiemagee/opentelemetry-collector
Oct 23, 2023
Merged
Allow running OpenTelemetry collector #181
jakecoffman
merged 5 commits into
dependabot:main
from
JamieMagee:jamiemagee/opentelemetry-collector
Oct 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanbrandenburg
approved these changes
Oct 18, 2023
jpinz
reviewed
Oct 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some questions/comments.
jakecoffman
reviewed
Oct 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of this might change if we decide on a different architecture so let's hold off merging this until then.
jakecoffman
reviewed
Oct 20, 2023
jakecoffman
reviewed
Oct 20, 2023
jakecoffman
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to run an OpenTelemetryCollector container image alongside the proxy and updater image. This depends on dependabot/dependabot-core#8210, which adds the OpenTelemetry SDK to
dependabot-core
.The main changes in this PR are:
enable-opentelemetry
a boolean flag to control if the OpenTelemetry collector container should be created, and theOTEL_ENABLED
environment variable should be passed to the updater containercollector-image
a string flag that controls which container image to use for the OpenTelemetry collector. Defaults toghcr.io/open-telemetry/opentelemetry-collector-releases/opentelemetry-collector-contrib:latest
. See the Dockerfile for this container image herecollector-config
a string flag that sets a path to OpenTelemetry collector YAML configuration. I've been using the following for testing:Click to expand