fix crash when unknown endpoint is called #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honeyankit
approved these changes
Sep 26, 2023
…wn-endpoint-is-used
jakecoffman
deleted the
jakecoffman/dont-crash-api-server-when-unknown-endpoint-is-used
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we forget to model a new call from the Updater and this results in the CLI crashing the API server it uses to intercept calls.
This change fixes the crash and returns a 501 instead. If the CLI is running a test, it already adds an error to it, this just prevents it from crashing. So it will proceed to finish the job instead.