Remove http basic auth from proxy (#3)

In github/dependabot-update-job-proxy#988 we're
removing HTTP Basic Auth from the proxy. While passing them won't cause
any issues, it will no longer serve a purpose.

It should technically be fine to merge these changes _before_ that
lands, as the proxy can currently be ran without setting up basic auth,
but let's get that PR to land first.

internal/infra/config.go

@@ -13,7 +13,6 @@ const ConfigFilePath = "/config.json"
 type Config struct {
 	Credentials []map[string]string  `json:"all_credentials"`
 	CA          CertificateAuthority `json:"ca"`
-	ProxyAuth   BasicAuthCredentials `json:"proxy_auth"`
 }
 
 // CertificateAuthority includes the MITM CA certificate and private key

internal/infra/proxy.go

@@ -49,15 +49,9 @@ func NewProxy(ctx context.Context, cli *client.Client, params *RunParams, nets .
 	}
 
 	// Generate and write configuration to disk:
-	username := "cli-user"
-	password := generatePassword()
 	proxyConfig := &Config{
 		Credentials: params.Creds,
-		ProxyAuth: BasicAuthCredentials{
-			Username: username,
-			Password: password,
-		},
-		CA: ca,
+		CA:          ca,
 	}
 	proxyConfigPath, err := StoreProxyConfig(params.TempDir, proxyConfig)
 	if err != nil {
@@ -111,7 +105,7 @@ func NewProxy(ctx context.Context, cli *client.Client, params *RunParams, nets .
 		cli:             cli,
 		containerID:     proxyContainer.ID,
 		containerName:   hostName,
-		url:             fmt.Sprintf("http://%s:%s@%s:1080", username, password, hostName),
+		url:             fmt.Sprintf("http://%s:1080", hostName),
 		CertPath:        certPath,
 		proxyConfigPath: proxyConfigPath,
 	}, nil