Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix environment check for web vitals #33337

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

acrollet
Copy link
Contributor

@acrollet acrollet commented Dec 4, 2024

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

⚠️ TeamSites ⚠️

Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the #sitewide-public-websites Slack channel for questions.

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

Fixing mistaken call to non-existent property instead of function. I verified that !environment.isProduction evaluates to false, so this will not affect behavior on production.

Related issue(s)

Testing done

Validated locally

@acrollet acrollet marked this pull request as ready for review December 4, 2024 17:33
@acrollet acrollet requested a review from a team as a code owner December 4, 2024 17:33
Copy link
Contributor

@rmessina1010 rmessina1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acrollet acrollet merged commit 2799915 into main Dec 4, 2024
76 of 78 checks passed
@acrollet acrollet deleted the bug/web-vitals/fix-environment-check branch December 4, 2024 19:44
Thrillberg pushed a commit that referenced this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants