Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appoint a rep QA #33302

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Appoint a rep QA #33302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8767b64
Removed duplicate text
cosu419 Dec 3, 2024
11ddca3
Reintroduce rep status widget
cosu419 Dec 3, 2024
2e52ce0
Added condition for authorize-outsize-va/names screen
cosu419 Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/applications/representative-appoint/components/SelectAccreditedRepresentative.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { useState, useRef } from 'react';

Check warning on line 1 in src/applications/representative-appoint/components/SelectAccreditedRepresentative.jsx

View workflow job for this annotation

GitHub Actions / App Isolation Annotations

Staged Continuous Deployment App Isolation Conflict 

*WARNING* This PR contains changes related to an application that is currently not isolated.
                
 As of Feb 3, 2025 deployment may no longer be possible for apps that are not isolated.
                
 Please isolate this app from other directories in 'src/applications' to prevent future deployment issues.
                
 More information on your app's status can be seen here: https://department-of-veterans-affairs.github.io/veteran-facing-services-tools/frontend-support-dashboard/cross-app-import-report
                
 Please reach out to Frontend Platform Support with any questions.
import { connect } from 'react-redux';
import { setData } from '~/platform/forms-system/src/js/actions';
import PropTypes from 'prop-types';
Expand Down Expand Up @@ -197,7 +197,7 @@
</p>
<va-link
href="/get-help-from-accredited-representative/find-rep"
text="Find a VA accredited representative or VSO (opens in new tab)"
text="Find a VA accredited representative or VSO"
external
/>
<FormNavButtons goBack={handleGoBack} goForward={handleGoForward} />
Expand Down
5 changes: 4 additions & 1 deletion src/applications/representative-appoint/config/form.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import commonDefinitions from 'vets-json-schema/dist/definitions.json';

Check warning on line 1 in src/applications/representative-appoint/config/form.js

View workflow job for this annotation

GitHub Actions / App Isolation Annotations

Staged Continuous Deployment App Isolation Conflict 

*WARNING* This PR contains changes related to an application that is currently not isolated.
                
 As of Feb 3, 2025 deployment may no longer be possible for apps that are not isolated.
                
 Please isolate this app from other directories in 'src/applications' to prevent future deployment issues.
                
 More information on your app's status can be seen here: https://department-of-veterans-affairs.github.io/veteran-facing-services-tools/frontend-support-dashboard/cross-app-import-report
                
 Please reach out to Frontend Platform Support with any questions.
import environment from '@department-of-veterans-affairs/platform-utilities/environment';
// import profileContactInfo from 'platform/forms-system/src/js/definitions/profileContactInfo';
import configService from '../utilities/configService';
Expand Down Expand Up @@ -378,7 +378,10 @@
authorizeOutsideVANames: {
path: 'authorize-outside-va/names',
depends: formData => {
return isAttorneyOrClaimsAgent(formData);
return (
isAttorneyOrClaimsAgent(formData) &&
formData.authorizeOutsideVARadio === 'Yes'
);
},
title: 'Authorization for Access Outside of VA Systems',
uiSchema: authorizeOutsideVANames.uiSchema,
Expand Down
19 changes: 8 additions & 11 deletions src/applications/representative-appoint/containers/IntroductionPage.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,29 +1,26 @@
import React, { useEffect } from 'react';

Check warning on line 1 in src/applications/representative-appoint/containers/IntroductionPage.jsx

View workflow job for this annotation

GitHub Actions / App Isolation Annotations

Staged Continuous Deployment App Isolation Conflict 

*WARNING* This PR contains changes related to an application that is currently not isolated.
                
 As of Feb 3, 2025 deployment may no longer be possible for apps that are not isolated.
                
 Please isolate this app from other directories in 'src/applications' to prevent future deployment issues.
                
 More information on your app's status can be seen here: https://department-of-veterans-affairs.github.io/veteran-facing-services-tools/frontend-support-dashboard/cross-app-import-report
                
 Please reach out to Frontend Platform Support with any questions.
import PropTypes from 'prop-types';
import { focusElement } from 'platform/utilities/ui';
import FormTitle from 'platform/forms-system/src/js/components/FormTitle';
import SaveInProgressIntro from 'platform/forms/save-in-progress/SaveInProgressIntro';
// import repStatusLoader from 'applications/static-pages/representative-status';
import {
// useStore,
connect,
} from 'react-redux';
import repStatusLoader from 'applications/static-pages/representative-status';

Check warning on line 6 in src/applications/representative-appoint/containers/IntroductionPage.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed) 

src/applications/representative-appoint/containers/IntroductionPage.jsx:6:1:No cross app imports allowed: representative-appoint importing from static-pages
import { useStore, connect } from 'react-redux';
import { isLoggedIn } from 'platform/user/selectors';
import GetFormHelp from '../components/GetFormHelp';

const IntroductionPage = props => {
const { route, loggedIn } = props;

Check warning on line 12 in src/applications/representative-appoint/containers/IntroductionPage.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed) 

src/applications/representative-appoint/containers/IntroductionPage.jsx:12:18:'loggedIn' is missing in props validation
const { formConfig, pageList } = route;
// const store = useStore();
const store = useStore();

useEffect(() => {
focusElement('.va-nav-breadcrumbs-list');
}, []);

// // search from query params on page load
// useEffect(() => {
// repStatusLoader(store, 'representative-status', 3, false);
// }, []);
// search from query params on page load
useEffect(() => {
repStatusLoader(store, 'representative-status', 3, false);
}, []);

Check warning on line 23 in src/applications/representative-appoint/containers/IntroductionPage.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed) 

src/applications/representative-appoint/containers/IntroductionPage.jsx:23:6:React Hook useEffect has a missing dependency: 'store'. Either include it or remove the dependency array.

return (
<article className="schemaform-intro">
Expand All @@ -44,7 +41,7 @@
</p>
<>
<div tabIndex="-1">
{/* <div data-widget-type="representative-status" /> */}
<div data-widget-type="representative-status" />
</div>
</>
</div>
Expand Down
Loading