Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aedp/aw/190/file organization cleanup vadx #33301

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

adamwhitlock1
Copy link
Contributor

@adamwhitlock1 adamwhitlock1 commented Dec 3, 2024

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

  • This is a tech debt / cleanup PR for the pattern team's codebase.
  • Since we we copying a lot of code over from other form apps, there ended up being a lot of code that was not needed for out user research prototypes. This PR removes those files and attempts to restructure out Pattern 2 Orange Task code into more understandable folders and naming conventions.
  • This is not the end of the refactor for the relate issue, but is a start and is sitting at 2000 loc removed so wanted to get this in as a PR before submitting more cleanup PRs.

Related issue(s)

Testing done

  • Verified that all existing TaskOrange and other Pattern 2 tasks function as desired
  • All unit and e2e tests passing

Screenshots

No UI changes just removal of dead code and organization of existing code

What areas of the site does it impact?

Authenticated Experience Design Patterns mock form app

Acceptance criteria

  • Code cleaned up for pattern 2 Orange Task

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

@va-vfs-bot va-vfs-bot temporarily deployed to master/aedp/aw/190/file-organization-cleanup-vadx/main December 3, 2024 04:25 Inactive
@adamwhitlock1 adamwhitlock1 marked this pull request as ready for review December 3, 2024 15:42
@adamwhitlock1 adamwhitlock1 requested review from a team as code owners December 3, 2024 15:42
Copy link
Contributor

@bellepx0 bellepx0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@adamwhitlock1 adamwhitlock1 merged commit 2f16961 into main Dec 4, 2024
71 of 72 checks passed
@adamwhitlock1 adamwhitlock1 deleted the aedp/aw/190/file-organization-cleanup-vadx branch December 4, 2024 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants