Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign-in widget: Remove some widget post-signin-alert content #33298

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

dcloud
Copy link
Contributor

@dcloud dcloud commented Dec 2, 2024

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

  • Removed content from widgets that is or will be obsolete as accepted account types changes
  • Removed a broken link to an MHV National Portal Classic page about MHV account types. MHV login accounts are going away January 2025
  • Removed mention of Premium MyHealtheVet account from ServiceProvidersList component

Related issue(s)

Testing done

  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected
  • Describe the tests completed and the results
  • _Exclusively stating 'Specs and automated tests passing' is NOT acceptable as appropriate testing
  • Optionally, provide a link to your test plan and test execution records

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Before After
Mobile Screen Shot 2024-12-03 at 13 51 08 Screen Shot 2024-12-03 at 14 01 56
Desktop Screen Shot 2024-12-03 at 13 50 58 Screen Shot 2024-12-03 at 14 01 33

What areas of the site does it impact?

(Describe what parts of the site are impacted if code touched other areas)

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

Should I delete ServiceProvidersList.jsx if this PR removes all the places it is currently used?

@dcloud dcloud changed the title Sign-in widget: Remove some post-alert content Sign-in widget: Remove some widget post-signin-alert content Dec 2, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to master/dcloud/98147-sign-in-admonitions/main December 2, 2024 23:38 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/dcloud/98147-sign-in-admonitions/main December 3, 2024 20:17 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/dcloud/98147-sign-in-admonitions/main December 3, 2024 20:53 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants